-
Notifications
You must be signed in to change notification settings - Fork 1
Fix CI workflow step names and add event listener cleanup #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: JaclynCodes <218383634+JaclynCodes@users.noreply.github.com>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [glob](https://github.com/isaacs/node-glob) from 10.4.5 to 10.5.0. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.4.5...v10.5.0) --- updated-dependencies: - dependency-name: glob dependency-version: 10.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…0.5.0 Chore(deps): bump glob from 10.4.5 to 10.5.0
…l-4.1.1 Chore(deps-dev): bump js-yaml from 4.1.0 to 4.1.1
…es (#6) Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/yahoo/serialize-javascript/releases) - [Commits](yahoo/serialize-javascript@v6.0.1...v6.0.2) --- updated-dependencies: - dependency-name: serialize-javascript dependency-version: 6.0.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>
* Add Codacy security scan workflow This workflow integrates Codacy security scans with GitHub Actions, checking code on push and pull requests to the main branch, and scheduling weekly scans. Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com> * Update .github/workflows/codacy.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com> * Update .github/workflows/codacy.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com> * Update .github/workflows/codacy.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com> --------- Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
… cleanup Co-authored-by: JaclynCodes <218383634+JaclynCodes@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses code quality issues identified in a previous code review by fixing documentation inconsistencies and preventing potential memory leaks.
- Updates CI workflow step names to accurately reflect Node.js 24.x usage
- Implements proper event listener cleanup in animation control components to prevent memory leaks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Updates all 6 step names from "Setup Node.js 22.x" to "Setup Node.js 24.x" to match actual configuration |
blend-trees-2d-directional.controls.mjs |
Adds cleanup return function in useEffect to remove mousemove and mousedown event listeners on unmount |
blend-trees-2d-cartesian.controls.mjs |
Refactors to use bound event handler and adds componentWillUnmount to clean up all 4 event listeners (mouse and touch events) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses CodeRabbit review comments on PR #8: mismatched Node.js version in step names and missing event listener cleanup causing potential memory leaks.
Changes
.github/workflows/ci.yml: Update all step names from "Setup Node.js 22.x" to "Setup Node.js 24.x" to match actualnode-version: 24.xblend-trees-2d-cartesian.controls.mjs: AddcomponentWillUnmountto clean up canvas event listenersblend-trees-2d-directional.controls.mjs: Add cleanup return function touseEffectfor proper listener removal on unmountOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.