-
Notifications
You must be signed in to change notification settings - Fork 234
Add Figure.directional_rose to plot a directional rose on map #4025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a46dc2c to
59f2b18
Compare
2cc02fb to
4b7b799
Compare
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded images
Modified images
Report last updated at commit 7ba2bda |
8078a84 to
1a8ea29
Compare
1a8ea29 to
f2f22c3
Compare
michaelgrund
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
be05942 to
c3954bf
Compare
6ab446b to
247ec6d
Compare
0851a2e to
173dd95
Compare
173dd95 to
7ba2bda
Compare
|
I think this feature is also ready for review. The key point that we need to reach an agreement on is the default position. As shown below, GMT defaults to plot directional roses at
I'll file an upstream issue report later (GenericMappingTools/gmt#8841), but I feel in PyGMT, we should let the default position to
|


Description of proposed changes
This PR adds the
Figure.directional_rosemethod to plot a map directional rose on map. It wraps thebasemap -Td/coast -Tdoptions.[g|j|J|n|x]<refpoint>[+j<justify>][+o<dx>[/<dy>]]:position+w<width>:width+f[<level>]:fancy+l<w,e,s,n>]:labelsExample
Preview: https://pygmt-dev--4025.org.readthedocs.build/en/4025/api/generated/pygmt.Figure.directional_rose.html
Addressing #2831. Related to #4010. Related to #4164.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code