Skip to content

feat: Harmonize XML tools in repository (with geos-xml-viewer) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alexbenedicto wants to merge 51 commits into
base: main
Choose a base branch
from
Open

feat: Harmonize XML tools in repository (with geos-xml-viewer) #120

alexbenedicto wants to merge 51 commits into from

Conversation

@alexbenedicto
Copy link
Collaborator

@alexbenedicto alexbenedicto commented Jul 30, 2025 •
edited
Loading

Closes #112 by:

  • removing geos-xml-viewer package
  • move its core functionalities if not duplicated inside geos-xml-tools
  • Remove geosDeckReader capability that is replaced by geos-trame package

@alexbenedicto
Move geos-xml-viewer to geos-xml-tools
f377617
@alexbenedicto
Update geos-xml-tools based scripts + test them
3214856
@alexbenedicto
Move testCellLocator to geos-mesh as test_cell_locator
c9b94a7
@alexbenedicto
Move write_wells to geos-xml-tools base functionalities
8ab37b9
@alexbenedicto
Remove non XML related scripts
fad6ed8
@alexbenedicto
Remove geosDeckReader vtk algorithm to be replaced by functionalities…
48eb6df 
… from geos-xml-tools
@alexbenedicto
Remove unused code
97f2c98
@alexbenedicto
Remove xsdata dependency
29a42bf
@alexbenedicto
yapf formatting
09c2381
@alexbenedicto
Test vtk_builder
3e3d655
@alexbenedicto
Update main.py to have access to new functionalities
da76610
@alexbenedicto
Change GEOSX to GEOS
37d039a
@alexbenedicto
Better handling functions
31cf392
@alexbenedicto
Add copyrights
2007fd2
@alexbenedicto
Remove write_wells because hardcoded and not used
298d8f3
@alexbenedicto
Fix for mypy
bfd01b9
@alexbenedicto
Ruff checking + yapf formatting
ec72d93
@alexbenedicto
Improve __doc__ for each file
8a44c4c
@alexbenedicto
Update sphinx documentation
5beb9a4
@alexbenedicto
Avoid setting an invalid wd if an error happens in process
e09e536
@alexbenedicto
Remove test_deckSource.py because is a duplicate of test_vtk_builder.py
27f093d
@alexbenedicto
Fix test isolation that would make other tests fail in the repo
b45e0d3
@alexbenedicto
Remove duplication and fix format in test_xml_processor
f6c4367
@alexbenedicto
Better handling of file generation anc deletion when running test_vtk…
e941b39 
…_builder
@alexbenedicto
Allow default region creation for VTKMesh
19e6b30
@alexbenedicto
Update conf.py
e4ba82a
@alexbenedicto
Add command line documentation
a2c8ea4
@alexbenedicto
Remove pyvista_viewer that is redundant with geos-trame
0f61ba5
@alexbenedicto
Better naming in docs
dc668d1
@alexbenedicto
Remove pyvista_viewer test
dd0db36
@alexbenedicto alexbenedicto self-assigned this Jul 30, 2025
RomainBaville
RomainBaville reviewed Aug 12, 2025
View reviewed changes
docs/geos_pv_docs/PVGeosDeckReader.rst Outdated
Copy link
Contributor

@RomainBaville RomainBaville Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not write the doc in the PVGeosDeckReader.py as for the other plugins ?

@alexbenedicto alexbenedicto added test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI flag: ready for review and removed DO NOT MERGE! labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainBaville RomainBaville RomainBaville left review comments

@paloma-martinez paloma-martinez Awaiting requested review from paloma-martinez

At least 1 approving review is required to merge this pull request.

Assignees

@alexbenedicto alexbenedicto

Labels

flag: ready for review test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI type: cleanup type: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove geos-xml-viewer and transfer its tools to geos-xml-tools

3 participants

@alexbenedicto @RomainBaville