Make watchify ignore node_modules by default #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Owner
|
I still want us to detect changes to node_modules by default, maybe we could be a bit more clever about it though (maybe only poll every 5 seconds or something). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any project with more than a few dependencies polling on the node_modules directory requires a lot of cpu (nearly 100% in my vm). Adding
ignoreWatch: trueto watchify's options to enable the following ignore pattern:ignoreWatch: ['**/node_modules/**']seems like a more sane default. This drastically reduces CPU usage when polling is enabled.Related to #96, but doesn't directly fix it.