-
Notifications
You must be signed in to change notification settings - Fork 320
Use consistent approach to apply temporary system-property overrides that have a desired side-effect #10239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcculls
wants to merge
2
commits into
master
Choose a base branch
from
mcculls/align-bytebuddy-overrides
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that have a desired side-effect
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~451157d5ed, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081499
Total [baseline] (10.901 s) : 0, 10900714
Agent [candidate] (1.089 s) : 0, 1088903
Total [candidate] (10.822 s) : 0, 10821895
section appsec
Agent [baseline] (1.273 s) : 0, 1273167
Total [baseline] (10.993 s) : 0, 10992560
Agent [candidate] (1.279 s) : 0, 1278747
Total [candidate] (10.979 s) : 0, 10979230
section iast
Agent [baseline] (1.232 s) : 0, 1232403
Total [baseline] (11.239 s) : 0, 11239491
Agent [candidate] (1.229 s) : 0, 1229149
Total [candidate] (11.258 s) : 0, 11257744
section profiling
Agent [baseline] (1.206 s) : 0, 1206282
Total [baseline] (10.95 s) : 0, 10949969
Agent [candidate] (1.21 s) : 0, 1209783
Total [candidate] (11.098 s) : 0, 11097751
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~451157d5ed, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (648.566 ms) : 0, 648566
BytebuddyAgent [candidate] (653.981 ms) : 0, 653981
GlobalTracer [baseline] (282.405 ms) : 0, 282405
GlobalTracer [candidate] (283.07 ms) : 0, 283070
AppSec [baseline] (32.179 ms) : 0, 32179
AppSec [candidate] (32.768 ms) : 0, 32768
Debugger [baseline] (68.189 ms) : 0, 68189
Debugger [candidate] (68.936 ms) : 0, 68936
Remote Config [baseline] (631.558 µs) : 0, 632
Remote Config [candidate] (629.047 µs) : 0, 629
Telemetry [baseline] (9.124 ms) : 0, 9124
Telemetry [candidate] (9.015 ms) : 0, 9015
Flare Poller [baseline] (3.756 ms) : 0, 3756
Flare Poller [candidate] (3.721 ms) : 0, 3721
section appsec
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (694.256 ms) : 0, 694256
BytebuddyAgent [candidate] (699.099 ms) : 0, 699099
GlobalTracer [baseline] (260.845 ms) : 0, 260845
GlobalTracer [candidate] (261.234 ms) : 0, 261234
AppSec [baseline] (175.791 ms) : 0, 175791
AppSec [candidate] (176.029 ms) : 0, 176029
Debugger [baseline] (66.899 ms) : 0, 66899
Debugger [candidate] (66.858 ms) : 0, 66858
Remote Config [baseline] (695.219 µs) : 0, 695
Remote Config [candidate] (776.402 µs) : 0, 776
Telemetry [baseline] (9.081 ms) : 0, 9081
Telemetry [candidate] (9.387 ms) : 0, 9387
Flare Poller [baseline] (3.955 ms) : 0, 3955
Flare Poller [candidate] (3.698 ms) : 0, 3698
IAST [baseline] (24.751 ms) : 0, 24751
IAST [candidate] (24.839 ms) : 0, 24839
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (796.808 ms) : 0, 796808
BytebuddyAgent [candidate] (794.783 ms) : 0, 794783
GlobalTracer [baseline] (258.139 ms) : 0, 258139
GlobalTracer [candidate] (257.045 ms) : 0, 257045
AppSec [baseline] (33.691 ms) : 0, 33691
AppSec [candidate] (33.766 ms) : 0, 33766
Debugger [baseline] (67.072 ms) : 0, 67072
Debugger [candidate] (67.048 ms) : 0, 67048
Remote Config [baseline] (574.136 µs) : 0, 574
Remote Config [candidate] (587.084 µs) : 0, 587
Telemetry [baseline] (8.519 ms) : 0, 8519
Telemetry [candidate] (8.578 ms) : 0, 8578
Flare Poller [baseline] (3.523 ms) : 0, 3523
Flare Poller [candidate] (3.57 ms) : 0, 3570
IAST [baseline] (27.333 ms) : 0, 27333
IAST [candidate] (27.148 ms) : 0, 27148
section profiling
ProfilingAgent [baseline] (97.629 ms) : 0, 97629
ProfilingAgent [candidate] (98.106 ms) : 0, 98106
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (701.864 ms) : 0, 701864
BytebuddyAgent [candidate] (705.584 ms) : 0, 705584
GlobalTracer [baseline] (221.278 ms) : 0, 221278
GlobalTracer [candidate] (221.155 ms) : 0, 221155
AppSec [baseline] (32.312 ms) : 0, 32312
AppSec [candidate] (32.165 ms) : 0, 32165
Debugger [baseline] (68.726 ms) : 0, 68726
Debugger [candidate] (68.454 ms) : 0, 68454
Remote Config [baseline] (644.026 µs) : 0, 644
Remote Config [candidate] (630.925 µs) : 0, 631
Telemetry [baseline] (8.97 ms) : 0, 8970
Telemetry [candidate] (8.722 ms) : 0, 8722
Flare Poller [baseline] (3.734 ms) : 0, 3734
Flare Poller [candidate] (3.71 ms) : 0, 3710
Profiling [baseline] (98.217 ms) : 0, 98217
Profiling [candidate] (98.693 ms) : 0, 98693
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~451157d5ed, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091144
Total [baseline] (8.811 s) : 0, 8810917
Agent [candidate] (1.086 s) : 0, 1086070
Total [candidate] (8.757 s) : 0, 8757390
section iast
Agent [baseline] (1.228 s) : 0, 1228358
Total [baseline] (9.371 s) : 0, 9370768
Agent [candidate] (1.24 s) : 0, 1239547
Total [candidate] (9.399 s) : 0, 9399295
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~451157d5ed, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (655.119 ms) : 0, 655119
BytebuddyAgent [candidate] (653.064 ms) : 0, 653064
GlobalTracer [baseline] (284.91 ms) : 0, 284910
GlobalTracer [candidate] (282.461 ms) : 0, 282461
AppSec [baseline] (32.713 ms) : 0, 32713
AppSec [candidate] (32.589 ms) : 0, 32589
Debugger [baseline] (67.864 ms) : 0, 67864
Debugger [candidate] (67.597 ms) : 0, 67597
Remote Config [baseline] (626.633 µs) : 0, 627
Remote Config [candidate] (627.285 µs) : 0, 627
Telemetry [baseline] (9.073 ms) : 0, 9073
Telemetry [candidate] (9.113 ms) : 0, 9113
Flare Poller [baseline] (3.764 ms) : 0, 3764
Flare Poller [candidate] (3.703 ms) : 0, 3703
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (793.943 ms) : 0, 793943
BytebuddyAgent [candidate] (802.838 ms) : 0, 802838
GlobalTracer [baseline] (257.681 ms) : 0, 257681
GlobalTracer [candidate] (258.406 ms) : 0, 258406
AppSec [baseline] (34.422 ms) : 0, 34422
AppSec [candidate] (34.797 ms) : 0, 34797
Debugger [baseline] (65.552 ms) : 0, 65552
Debugger [candidate] (65.885 ms) : 0, 65885
Remote Config [baseline] (623.448 µs) : 0, 623
Remote Config [candidate] (609.873 µs) : 0, 610
Telemetry [baseline] (8.527 ms) : 0, 8527
Telemetry [candidate] (8.698 ms) : 0, 8698
Flare Poller [baseline] (3.591 ms) : 0, 3591
Flare Poller [candidate] (3.672 ms) : 0, 3672
IAST [baseline] (27.373 ms) : 0, 27373
IAST [candidate] (27.639 ms) : 0, 27639
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~451157d5ed, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1175, 1199
. : milestone, 1187,
iast (3.244 ms) : 3200, 3288
. : milestone, 3244,
iast_FULL (5.801 ms) : 5742, 5861
. : milestone, 5801,
iast_GLOBAL (3.673 ms) : 3618, 3728
. : milestone, 3673,
profiling (2.019 ms) : 2001, 2036
. : milestone, 2019,
tracing (1.796 ms) : 1781, 1811
. : milestone, 1796,
section candidate
no_agent (1.191 ms) : 1179, 1204
. : milestone, 1191,
iast (3.211 ms) : 3169, 3253
. : milestone, 3211,
iast_FULL (5.773 ms) : 5716, 5830
. : milestone, 5773,
iast_GLOBAL (3.439 ms) : 3386, 3491
. : milestone, 3439,
profiling (2.193 ms) : 2171, 2215
. : milestone, 2193,
tracing (1.832 ms) : 1816, 1848
. : milestone, 1832,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~451157d5ed, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section baseline
no_agent (18.398 ms) : 18209, 18587
. : milestone, 18398,
appsec (18.737 ms) : 18546, 18928
. : milestone, 18737,
code_origins (17.749 ms) : 17571, 17926
. : milestone, 17749,
iast (17.745 ms) : 17567, 17923
. : milestone, 17745,
profiling (18.56 ms) : 18372, 18747
. : milestone, 18560,
tracing (17.848 ms) : 17672, 18023
. : milestone, 17848,
section candidate
no_agent (18.226 ms) : 18036, 18415
. : milestone, 18226,
appsec (19.068 ms) : 18874, 19262
. : milestone, 19068,
code_origins (18.958 ms) : 18767, 19149
. : milestone, 18958,
iast (18.001 ms) : 17821, 18180
. : milestone, 18001,
profiling (19.041 ms) : 18848, 19233
. : milestone, 19041,
tracing (17.7 ms) : 17525, 17876
. : milestone, 17700,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~451157d5ed, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section baseline
no_agent (15.473 s) : 15473000, 15473000
. : milestone, 15473000,
appsec (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
iast (18.689 s) : 18689000, 18689000
. : milestone, 18689000,
iast_GLOBAL (17.781 s) : 17781000, 17781000
. : milestone, 17781000,
profiling (14.714 s) : 14714000, 14714000
. : milestone, 14714000,
tracing (14.857 s) : 14857000, 14857000
. : milestone, 14857000,
section candidate
no_agent (14.752 s) : 14752000, 14752000
. : milestone, 14752000,
appsec (14.751 s) : 14751000, 14751000
. : milestone, 14751000,
iast (18.318 s) : 18318000, 18318000
. : milestone, 18318000,
iast_GLOBAL (17.927 s) : 17927000, 17927000
. : milestone, 17927000,
profiling (14.786 s) : 14786000, 14786000
. : milestone, 14786000,
tracing (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~451157d5ed, baseline=1.58.0-SNAPSHOT~6ccbc0607e
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.642 ms) : 3428, 3856
. : milestone, 3642,
iast (2.196 ms) : 2132, 2260
. : milestone, 2196,
iast_GLOBAL (2.239 ms) : 2175, 2304
. : milestone, 2239,
profiling (2.082 ms) : 2028, 2136
. : milestone, 2082,
tracing (2.04 ms) : 1989, 2091
. : milestone, 2040,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (3.617 ms) : 3403, 3831
. : milestone, 3617,
iast (2.202 ms) : 2138, 2267
. : milestone, 2202,
iast_GLOBAL (2.244 ms) : 2179, 2309
. : milestone, 2244,
profiling (2.467 ms) : 2306, 2628
. : milestone, 2467,
tracing (2.03 ms) : 1980, 2081
. : milestone, 2030,
|
dougqh
approved these changes
Dec 18, 2025
amarziali
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
More codebase consistency
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]