-
Notifications
You must be signed in to change notification settings - Fork 320
Move macrobenchmarks to apm-sdks-benchmarks repo
#10066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sarahchen6
wants to merge
21
commits into
master
Choose a base branch
from
sarahchen6/move-macrobenchmarks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f391147 to
9602f73
Compare
ba1ae21 to
b376785
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~c3f9431502, baseline=1.57.0-SNAPSHOT~5477fa0d27
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078501
Total [baseline] (10.883 s) : 0, 10883410
Agent [candidate] (1.084 s) : 0, 1084243
Total [candidate] (10.875 s) : 0, 10874914
section appsec
Agent [baseline] (1.263 s) : 0, 1262647
Total [baseline] (11.019 s) : 0, 11019081
Agent [candidate] (1.259 s) : 0, 1259004
Total [candidate] (11.039 s) : 0, 11038548
section iast
Agent [baseline] (1.216 s) : 0, 1216372
Total [baseline] (11.246 s) : 0, 11245527
Agent [candidate] (1.216 s) : 0, 1215611
Total [candidate] (11.156 s) : 0, 11156125
section profiling
Agent [baseline] (1.209 s) : 0, 1209391
Total [baseline] (10.999 s) : 0, 10999457
Agent [candidate] (1.208 s) : 0, 1207918
Total [candidate] (10.995 s) : 0, 10995136
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~c3f9431502, baseline=1.57.0-SNAPSHOT~5477fa0d27
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.171 ms) : 0, 1171
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (647.008 ms) : 0, 647008
BytebuddyAgent [candidate] (650.481 ms) : 0, 650481
GlobalTracer [baseline] (281.72 ms) : 0, 281720
GlobalTracer [candidate] (283.343 ms) : 0, 283343
AppSec [baseline] (32.146 ms) : 0, 32146
AppSec [candidate] (32.433 ms) : 0, 32433
Debugger [baseline] (67.594 ms) : 0, 67594
Debugger [candidate] (68.167 ms) : 0, 68167
Remote Config [baseline] (619.318 µs) : 0, 619
Remote Config [candidate] (595.348 µs) : 0, 595
Telemetry [baseline] (9.027 ms) : 0, 9027
Telemetry [candidate] (8.857 ms) : 0, 8857
Flare Poller [baseline] (3.794 ms) : 0, 3794
Flare Poller [candidate] (3.758 ms) : 0, 3758
section appsec
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (688.282 ms) : 0, 688282
BytebuddyAgent [candidate] (686.144 ms) : 0, 686144
GlobalTracer [baseline] (258.613 ms) : 0, 258613
GlobalTracer [candidate] (257.585 ms) : 0, 257585
AppSec [baseline] (171.544 ms) : 0, 171544
AppSec [candidate] (171.853 ms) : 0, 171853
Debugger [baseline] (69.242 ms) : 0, 69242
Debugger [candidate] (68.605 ms) : 0, 68605
Remote Config [baseline] (698.134 µs) : 0, 698
Remote Config [candidate] (723.075 µs) : 0, 723
Telemetry [baseline] (9.125 ms) : 0, 9125
Telemetry [candidate] (9.067 ms) : 0, 9067
Flare Poller [baseline] (3.801 ms) : 0, 3801
Flare Poller [candidate] (3.918 ms) : 0, 3918
IAST [baseline] (24.634 ms) : 0, 24634
IAST [candidate] (24.469 ms) : 0, 24469
section iast
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (786.275 ms) : 0, 786275
BytebuddyAgent [candidate] (784.771 ms) : 0, 784771
GlobalTracer [baseline] (254.67 ms) : 0, 254670
GlobalTracer [candidate] (254.7 ms) : 0, 254700
AppSec [baseline] (34.201 ms) : 0, 34201
AppSec [candidate] (34.044 ms) : 0, 34044
Debugger [baseline] (65.426 ms) : 0, 65426
Debugger [candidate] (66.289 ms) : 0, 66289
Remote Config [baseline] (593.549 µs) : 0, 594
Remote Config [candidate] (573.118 µs) : 0, 573
Telemetry [baseline] (8.418 ms) : 0, 8418
Telemetry [candidate] (8.414 ms) : 0, 8414
Flare Poller [baseline] (3.464 ms) : 0, 3464
Flare Poller [candidate] (3.491 ms) : 0, 3491
IAST [baseline] (26.881 ms) : 0, 26881
IAST [candidate] (26.997 ms) : 0, 26997
section profiling
ProfilingAgent [baseline] (97.163 ms) : 0, 97163
ProfilingAgent [candidate] (97.509 ms) : 0, 97509
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (704.487 ms) : 0, 704487
BytebuddyAgent [candidate] (702.209 ms) : 0, 702209
GlobalTracer [baseline] (221.751 ms) : 0, 221751
GlobalTracer [candidate] (222.024 ms) : 0, 222024
AppSec [baseline] (32.37 ms) : 0, 32370
AppSec [candidate] (32.568 ms) : 0, 32568
Debugger [baseline] (69.116 ms) : 0, 69116
Debugger [candidate] (68.907 ms) : 0, 68907
Remote Config [baseline] (653.579 µs) : 0, 654
Remote Config [candidate] (644.156 µs) : 0, 644
Telemetry [baseline] (8.905 ms) : 0, 8905
Telemetry [candidate] (8.869 ms) : 0, 8869
Flare Poller [baseline] (3.785 ms) : 0, 3785
Flare Poller [candidate] (3.779 ms) : 0, 3779
Profiling [baseline] (97.747 ms) : 0, 97747
Profiling [candidate] (98.092 ms) : 0, 98092
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~c3f9431502, baseline=1.57.0-SNAPSHOT~5477fa0d27
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081586
Total [baseline] (8.768 s) : 0, 8767730
Agent [candidate] (1.081 s) : 0, 1081072
Total [candidate] (8.744 s) : 0, 8744486
section iast
Agent [baseline] (1.219 s) : 0, 1219159
Total [baseline] (9.344 s) : 0, 9343803
Agent [candidate] (1.219 s) : 0, 1219033
Total [candidate] (9.322 s) : 0, 9322235
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~c3f9431502, baseline=1.57.0-SNAPSHOT~5477fa0d27
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (649.541 ms) : 0, 649541
BytebuddyAgent [candidate] (649.345 ms) : 0, 649345
GlobalTracer [baseline] (282.31 ms) : 0, 282310
GlobalTracer [candidate] (282.631 ms) : 0, 282631
AppSec [baseline] (32.405 ms) : 0, 32405
AppSec [candidate] (32.178 ms) : 0, 32178
Debugger [baseline] (66.443 ms) : 0, 66443
Debugger [candidate] (66.677 ms) : 0, 66677
Remote Config [baseline] (617.574 µs) : 0, 618
Remote Config [candidate] (650.298 µs) : 0, 650
Telemetry [baseline] (9.077 ms) : 0, 9077
Telemetry [candidate] (9.121 ms) : 0, 9121
Flare Poller [baseline] (4.595 ms) : 0, 4595
Flare Poller [candidate] (3.876 ms) : 0, 3876
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (788.686 ms) : 0, 788686
BytebuddyAgent [candidate] (788.597 ms) : 0, 788597
GlobalTracer [baseline] (254.921 ms) : 0, 254921
GlobalTracer [candidate] (255.169 ms) : 0, 255169
AppSec [baseline] (33.4 ms) : 0, 33400
AppSec [candidate] (35.029 ms) : 0, 35029
Debugger [baseline] (66.162 ms) : 0, 66162
Debugger [candidate] (64.248 ms) : 0, 64248
Remote Config [baseline] (606.577 µs) : 0, 607
Remote Config [candidate] (582.531 µs) : 0, 583
Telemetry [baseline] (8.487 ms) : 0, 8487
Telemetry [candidate] (8.399 ms) : 0, 8399
Flare Poller [baseline] (3.487 ms) : 0, 3487
Flare Poller [candidate] (3.499 ms) : 0, 3499
IAST [baseline] (26.991 ms) : 0, 26991
IAST [candidate] (27.07 ms) : 0, 27070
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~c3f9431502, baseline=1.57.0-SNAPSHOT~5477fa0d27
dateFormat X
axisFormat %s
section baseline
no_agent (1.174 ms) : 1162, 1186
. : milestone, 1174,
iast (3.176 ms) : 3133, 3220
. : milestone, 3176,
iast_FULL (5.704 ms) : 5647, 5761
. : milestone, 5704,
iast_GLOBAL (3.539 ms) : 3487, 3590
. : milestone, 3539,
profiling (1.937 ms) : 1922, 1953
. : milestone, 1937,
tracing (1.841 ms) : 1824, 1858
. : milestone, 1841,
section candidate
no_agent (1.183 ms) : 1172, 1194
. : milestone, 1183,
iast (3.146 ms) : 3110, 3183
. : milestone, 3146,
iast_FULL (5.685 ms) : 5628, 5742
. : milestone, 5685,
iast_GLOBAL (3.599 ms) : 3544, 3654
. : milestone, 3599,
profiling (1.993 ms) : 1976, 2010
. : milestone, 1993,
tracing (1.762 ms) : 1748, 1776
. : milestone, 1762,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~c3f9431502, baseline=1.57.0-SNAPSHOT~5477fa0d27
dateFormat X
axisFormat %s
section baseline
no_agent (17.906 ms) : 17722, 18090
. : milestone, 17906,
appsec (18.562 ms) : 18373, 18751
. : milestone, 18562,
code_origins (19.015 ms) : 18825, 19205
. : milestone, 19015,
iast (17.966 ms) : 17787, 18146
. : milestone, 17966,
profiling (18.434 ms) : 18247, 18621
. : milestone, 18434,
tracing (17.691 ms) : 17514, 17868
. : milestone, 17691,
section candidate
no_agent (18.136 ms) : 17948, 18324
. : milestone, 18136,
appsec (18.406 ms) : 18223, 18588
. : milestone, 18406,
code_origins (17.629 ms) : 17458, 17799
. : milestone, 17629,
iast (17.51 ms) : 17337, 17682
. : milestone, 17510,
profiling (18.634 ms) : 18450, 18818
. : milestone, 18634,
tracing (17.541 ms) : 17363, 17719
. : milestone, 17541,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~c3f9431502, baseline=1.57.0-SNAPSHOT~5477fa0d27
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.702 ms) : 3482, 3922
. : milestone, 3702,
iast (2.206 ms) : 2142, 2270
. : milestone, 2206,
iast_GLOBAL (2.248 ms) : 2182, 2313
. : milestone, 2248,
profiling (2.067 ms) : 2014, 2119
. : milestone, 2067,
tracing (2.029 ms) : 1979, 2080
. : milestone, 2029,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.663 ms) : 3448, 3877
. : milestone, 3663,
iast (2.208 ms) : 2144, 2273
. : milestone, 2208,
iast_GLOBAL (2.254 ms) : 2189, 2318
. : milestone, 2254,
profiling (2.066 ms) : 2014, 2119
. : milestone, 2066,
tracing (2.033 ms) : 1982, 2083
. : milestone, 2033,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~c3f9431502, baseline=1.57.0-SNAPSHOT~5477fa0d27
dateFormat X
axisFormat %s
section baseline
no_agent (15.371 s) : 15371000, 15371000
. : milestone, 15371000,
appsec (14.84 s) : 14840000, 14840000
. : milestone, 14840000,
iast (18.381 s) : 18381000, 18381000
. : milestone, 18381000,
iast_GLOBAL (17.703 s) : 17703000, 17703000
. : milestone, 17703000,
profiling (14.629 s) : 14629000, 14629000
. : milestone, 14629000,
tracing (14.591 s) : 14591000, 14591000
. : milestone, 14591000,
section candidate
no_agent (15.084 s) : 15084000, 15084000
. : milestone, 15084000,
appsec (14.373 s) : 14373000, 14373000
. : milestone, 14373000,
iast (18.273 s) : 18273000, 18273000
. : milestone, 18273000,
iast_GLOBAL (17.656 s) : 17656000, 17656000
. : milestone, 17656000,
profiling (14.626 s) : 14626000, 14626000
. : milestone, 14626000,
tracing (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Now that our macrobenchmarks have been moved to the
apm-sdks-benchmarksrepo (https://github.com/DataDog/apm-sdks-benchmarks/pull/34), we can remove the local implementation.Motivation
Additional Notes
Before totally moving macrobenchmarks to the
apm-sdks-benchmarksrepo, we need to ensure OE reporting is not disrupted. Currently, OE may reportapm-sdks-benchmarksinstead ofdd-trace-javafor the benchmarks.To check this PR, see the manually triggered macrobenchmark runs in CI: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/86577685. Note that we'll have to confirm that they're automatically run on
masterand when scheduled (ref).Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-715