-
Notifications
You must be signed in to change notification settings - Fork 320
Enabling optimized map by default #10016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~65d63fe05c, baseline=1.57.0-SNAPSHOT~6836076eba
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076310
Total [baseline] (8.707 s) : 0, 8706754
Agent [candidate] (1.077 s) : 0, 1076535
Total [candidate] (8.726 s) : 0, 8725649
section iast
Agent [baseline] (1.227 s) : 0, 1227374
Total [baseline] (9.471 s) : 0, 9471216
Agent [candidate] (1.22 s) : 0, 1220363
Total [candidate] (9.48 s) : 0, 9479858
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~65d63fe05c, baseline=1.57.0-SNAPSHOT~6836076eba
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (645.958 ms) : 0, 645958
BytebuddyAgent [candidate] (647.395 ms) : 0, 647395
GlobalTracer [baseline] (280.989 ms) : 0, 280989
GlobalTracer [candidate] (280.235 ms) : 0, 280235
AppSec [baseline] (32.371 ms) : 0, 32371
AppSec [candidate] (32.055 ms) : 0, 32055
Debugger [baseline] (67.038 ms) : 0, 67038
Debugger [candidate] (66.839 ms) : 0, 66839
Remote Config [baseline] (661.264 µs) : 0, 661
Remote Config [candidate] (662.911 µs) : 0, 663
Telemetry [baseline] (9.023 ms) : 0, 9023
Telemetry [candidate] (9.043 ms) : 0, 9043
Flare Poller [baseline] (3.698 ms) : 0, 3698
Flare Poller [candidate] (3.705 ms) : 0, 3705
section iast
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (794.545 ms) : 0, 794545
BytebuddyAgent [candidate] (789.104 ms) : 0, 789104
GlobalTracer [baseline] (256.497 ms) : 0, 256497
GlobalTracer [candidate] (255.803 ms) : 0, 255803
IAST [baseline] (27.037 ms) : 0, 27037
IAST [candidate] (26.98 ms) : 0, 26980
AppSec [baseline] (35.478 ms) : 0, 35478
AppSec [candidate] (35.086 ms) : 0, 35086
Debugger [baseline] (64.664 ms) : 0, 64664
Debugger [candidate] (64.231 ms) : 0, 64231
Remote Config [baseline] (548.647 µs) : 0, 549
Remote Config [candidate] (559.395 µs) : 0, 559
Telemetry [baseline] (8.466 ms) : 0, 8466
Telemetry [candidate] (8.45 ms) : 0, 8450
Flare Poller [baseline] (3.461 ms) : 0, 3461
Flare Poller [candidate] (3.553 ms) : 0, 3553
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~65d63fe05c, baseline=1.57.0-SNAPSHOT~6836076eba
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078772
Total [baseline] (10.791 s) : 0, 10790861
Agent [candidate] (1.079 s) : 0, 1079441
Total [candidate] (10.808 s) : 0, 10807513
section appsec
Agent [baseline] (1.263 s) : 0, 1263365
Total [baseline] (11.083 s) : 0, 11082614
Agent [candidate] (1.266 s) : 0, 1266254
Total [candidate] (11.114 s) : 0, 11114165
section iast
Agent [baseline] (1.223 s) : 0, 1223092
Total [baseline] (11.124 s) : 0, 11123868
Agent [candidate] (1.222 s) : 0, 1222398
Total [candidate] (11.257 s) : 0, 11257305
section profiling
Agent [baseline] (1.206 s) : 0, 1205841
Total [baseline] (11.106 s) : 0, 11106035
Agent [candidate] (1.203 s) : 0, 1202991
Total [candidate] (10.953 s) : 0, 10953154
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~65d63fe05c, baseline=1.57.0-SNAPSHOT~6836076eba
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (647.327 ms) : 0, 647327
BytebuddyAgent [candidate] (648.663 ms) : 0, 648663
GlobalTracer [baseline] (280.919 ms) : 0, 280919
GlobalTracer [candidate] (280.96 ms) : 0, 280960
AppSec [baseline] (32.413 ms) : 0, 32413
AppSec [candidate] (32.318 ms) : 0, 32318
Debugger [baseline] (67.986 ms) : 0, 67986
Debugger [candidate] (67.484 ms) : 0, 67484
Remote Config [baseline] (647.216 µs) : 0, 647
Remote Config [candidate] (630.969 µs) : 0, 631
Telemetry [baseline] (9.112 ms) : 0, 9112
Telemetry [candidate] (9.02 ms) : 0, 9020
Flare Poller [baseline] (3.758 ms) : 0, 3758
Flare Poller [candidate] (3.736 ms) : 0, 3736
section appsec
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (688.599 ms) : 0, 688599
BytebuddyAgent [candidate] (688.917 ms) : 0, 688917
GlobalTracer [baseline] (259.297 ms) : 0, 259297
GlobalTracer [candidate] (259.116 ms) : 0, 259116
IAST [baseline] (24.648 ms) : 0, 24648
IAST [candidate] (24.64 ms) : 0, 24640
AppSec [baseline] (174.781 ms) : 0, 174781
AppSec [candidate] (175.618 ms) : 0, 175618
Debugger [baseline] (66.009 ms) : 0, 66009
Debugger [candidate] (67.26 ms) : 0, 67260
Remote Config [baseline] (693.981 µs) : 0, 694
Remote Config [candidate] (726.286 µs) : 0, 726
Telemetry [baseline] (8.856 ms) : 0, 8856
Telemetry [candidate] (9.216 ms) : 0, 9216
Flare Poller [baseline] (3.87 ms) : 0, 3870
Flare Poller [candidate] (3.966 ms) : 0, 3966
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (791.018 ms) : 0, 791018
BytebuddyAgent [candidate] (790.228 ms) : 0, 790228
GlobalTracer [baseline] (255.681 ms) : 0, 255681
GlobalTracer [candidate] (255.82 ms) : 0, 255820
IAST [baseline] (26.86 ms) : 0, 26860
IAST [candidate] (26.975 ms) : 0, 26975
AppSec [baseline] (34.227 ms) : 0, 34227
AppSec [candidate] (35.286 ms) : 0, 35286
Debugger [baseline] (66.423 ms) : 0, 66423
Debugger [candidate] (65.107 ms) : 0, 65107
Remote Config [baseline] (546.237 µs) : 0, 546
Remote Config [candidate] (564.535 µs) : 0, 565
Telemetry [baseline] (8.399 ms) : 0, 8399
Telemetry [candidate] (8.443 ms) : 0, 8443
Flare Poller [baseline] (3.457 ms) : 0, 3457
Flare Poller [candidate] (3.491 ms) : 0, 3491
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (703.155 ms) : 0, 703155
BytebuddyAgent [candidate] (699.95 ms) : 0, 699950
GlobalTracer [baseline] (220.183 ms) : 0, 220183
GlobalTracer [candidate] (220.72 ms) : 0, 220720
AppSec [baseline] (32.202 ms) : 0, 32202
AppSec [candidate] (32.32 ms) : 0, 32320
Debugger [baseline] (68.079 ms) : 0, 68079
Debugger [candidate] (68.167 ms) : 0, 68167
Remote Config [baseline] (609.724 µs) : 0, 610
Remote Config [candidate] (647.567 µs) : 0, 648
Telemetry [baseline] (9.068 ms) : 0, 9068
Telemetry [candidate] (8.969 ms) : 0, 8969
Flare Poller [baseline] (3.722 ms) : 0, 3722
Flare Poller [candidate] (3.764 ms) : 0, 3764
ProfilingAgent [baseline] (97.922 ms) : 0, 97922
ProfilingAgent [candidate] (97.725 ms) : 0, 97725
Profiling [baseline] (98.514 ms) : 0, 98514
Profiling [candidate] (98.31 ms) : 0, 98310
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 19 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~65d63fe05c, baseline=1.57.0-SNAPSHOT~6836076eba
dateFormat X
axisFormat %s
section baseline
no_agent (1.343 ms) : 1330, 1357
. : milestone, 1343,
iast (3.466 ms) : 3413, 3520
. : milestone, 3466,
iast_FULL (6.251 ms) : 6186, 6316
. : milestone, 6251,
iast_GLOBAL (3.857 ms) : 3800, 3913
. : milestone, 3857,
profiling (2.253 ms) : 2228, 2277
. : milestone, 2253,
tracing (1.937 ms) : 1921, 1953
. : milestone, 1937,
section candidate
no_agent (1.313 ms) : 1301, 1326
. : milestone, 1313,
iast (3.548 ms) : 3490, 3605
. : milestone, 3548,
iast_FULL (6.229 ms) : 6163, 6294
. : milestone, 6229,
iast_GLOBAL (3.844 ms) : 3779, 3909
. : milestone, 3844,
profiling (2.323 ms) : 2301, 2344
. : milestone, 2323,
tracing (1.977 ms) : 1961, 1993
. : milestone, 1977,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~65d63fe05c, baseline=1.57.0-SNAPSHOT~6836076eba
dateFormat X
axisFormat %s
section baseline
no_agent (18.625 ms) : 18433, 18817
. : milestone, 18625,
appsec (19.27 ms) : 19070, 19470
. : milestone, 19270,
code_origins (18.378 ms) : 18194, 18562
. : milestone, 18378,
iast (18.136 ms) : 17953, 18318
. : milestone, 18136,
profiling (19.332 ms) : 19138, 19526
. : milestone, 19332,
tracing (19.384 ms) : 19186, 19583
. : milestone, 19384,
section candidate
no_agent (19.571 ms) : 19367, 19776
. : milestone, 19571,
appsec (21.563 ms) : 21340, 21786
. : milestone, 21563,
code_origins (18.272 ms) : 18091, 18452
. : milestone, 18272,
iast (18.227 ms) : 18048, 18406
. : milestone, 18227,
profiling (20.13 ms) : 19923, 20336
. : milestone, 20130,
tracing (18.351 ms) : 18164, 18538
. : milestone, 18351,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~65d63fe05c, baseline=1.57.0-SNAPSHOT~6836076eba
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.706 ms) : 3487, 3924
. : milestone, 3706,
iast (2.218 ms) : 2153, 2282
. : milestone, 2218,
iast_GLOBAL (2.252 ms) : 2188, 2317
. : milestone, 2252,
profiling (2.085 ms) : 2032, 2139
. : milestone, 2085,
tracing (2.044 ms) : 1993, 2094
. : milestone, 2044,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.465 ms) : 2413, 2517
. : milestone, 2465,
iast (2.215 ms) : 2151, 2280
. : milestone, 2215,
iast_GLOBAL (2.259 ms) : 2194, 2324
. : milestone, 2259,
profiling (2.062 ms) : 2010, 2114
. : milestone, 2062,
tracing (2.037 ms) : 1987, 2088
. : milestone, 2037,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~65d63fe05c, baseline=1.57.0-SNAPSHOT~6836076eba
dateFormat X
axisFormat %s
section baseline
no_agent (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
appsec (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
iast (17.799 s) : 17799000, 17799000
. : milestone, 17799000,
iast_GLOBAL (17.894 s) : 17894000, 17894000
. : milestone, 17894000,
profiling (14.676 s) : 14676000, 14676000
. : milestone, 14676000,
tracing (14.638 s) : 14638000, 14638000
. : milestone, 14638000,
section candidate
no_agent (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
appsec (14.677 s) : 14677000, 14677000
. : milestone, 14677000,
iast (18.484 s) : 18484000, 18484000
. : milestone, 18484000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (14.409 s) : 14409000, 14409000
. : milestone, 14409000,
tracing (14.61 s) : 14610000, 14610000
. : milestone, 14610000,
|
|
|
||
| this.optimizedMapEnabled = | ||
| configProvider.getBoolean(GeneralConfig.OPTIMIZED_MAP_ENABLED, false); | ||
| this.optimizedMapEnabled = configProvider.getBoolean(GeneralConfig.OPTIMIZED_MAP_ENABLED, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, if it is a config change, do we need to update some other place too?
@mhlidd Could you check this PR too?
What Does This Do
Enables the "optimized" TagMap by default
Motivation
OptimizedTagMap is special HashMap that is designed to be good at common tracer usage patterns.
OptimizedTagMap uses immutable TagMap.Entry-s
By using immutable TagMap.Entry-s...
TagMap.Entry-s are also capable of storing primitives without boxing
All of these capabilities are intended to minimize the allocation done by the tracer when constructing Span-s
Additional Notes
Follow-up to
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]