Spring cleaning #101
Merged
Spring cleaning #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to have one file per model, fix matbench_example for wrenformer with the custom trainer
CompRhys
force-pushed
the
spring-cleaning
branch
from
cfbb5bb to
5f84d26
Compare
…to the InMemoryDataLoader of the wrenformer
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the codebase to remove the second flavour of trainer logic that was added with wrenformer. This will hopefully make it easier to modernize the trainer in the future without the tech debt of having to support two approaches. The wrenformer specific trainer has been kept in the examples alongside the matbench_example.
TODO: