Skip to content

Conversation

@vickimzhang
Copy link
Collaborator

@vickimzhang vickimzhang commented Dec 11, 2025

Update conda yml file to include specific versions that work for Linux and windows.

Summary by CodeRabbit

  • Chores

    • Package version bumped to 2.1.1 and environment spec upgraded to version 3.
    • Defaults channel added to environment sources.
    • Dependency set drastically reduced to three core packages, simplifying installation and speeding resolution.
  • Removed

    • Two example spatial modules (transformations, datasheets and layouts) and their associated runtime steps were removed, reducing surface area and UI artifacts.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025

Walkthrough

Updated package version to 2.1.1 and bumped the transformer condaEnvVersion to 3. The conda environment file adds the defaults channel and reduces dependencies to three R packages. Four Spatial example files and their manifests were removed entirely.

Changes

Cohort / File(s) Change Summary
Conda Environment Configuration
src/helloworldR.yml
Added defaults channel to environment sources and reduced dependencies to three packages: r-base=4.1.3, r-rsyncrosim=2.1.7, r-terra=1.5_21 (removed previous extensive / conda-forge / Windows-specific deps).
Package Version and Metadata
src/package.xml
Bumped package version from 2.1.0 to 2.1.1. Updated transformer firstModel attribute condaEnvVersion from 2 to 3.
Removed Spatial1 implementation
helloworldSpatial1/model.R, helloworldSpatial1/package.xml
Deleted model.R (entire R transformation script) and package.xml manifest defining RunControl, InputDatasheet, IntermediateDatasheet, transformer, layouts and charts.
Removed Spatial2 implementation
helloworldSpatial2/model2.R, helloworldSpatial2/package.xml
Deleted model2.R (entire R transformation script) and package.xml manifest defining OutputDatasheet, transformer, and layouts.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'vz update conda yml' accurately describes the main change: updating the conda environment file (src/helloworldR.yml) with specific package versions for cross-platform compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vz-update-conda-yml

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c9dddc and f601584.

⛔ Files ignored due to path filters (1)
  • helloworldSpatial2/templates/example-library.png is excluded by !**/*.png
📒 Files selected for processing (4)
  • helloworldSpatial1/model.R (0 hunks)
  • helloworldSpatial1/package.xml (0 hunks)
  • helloworldSpatial2/model2.R (0 hunks)
  • helloworldSpatial2/package.xml (0 hunks)
💤 Files with no reviewable changes (4)
  • helloworldSpatial2/package.xml
  • helloworldSpatial2/model2.R
  • helloworldSpatial1/model.R
  • helloworldSpatial1/package.xml

Comment @coderabbitai help to get the list of available commands and usage tips.

@vickimzhang vickimzhang requested a review from katieb1 December 11, 2025 18:54
Copy link
Member

@katieb1 katieb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also be able to remove the following folders from this repo:
image

The example library used to be the template library, but now we store these on S3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants