Fix various lints #149
Merged
Fix various lints #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjunetime
approved these changes
Oct 30, 2025
academician
force-pushed
the
lint-fixes
branch
2 times, most recently
from
2c13455 to
ca76e48
Compare
academician
force-pushed
the
lint-fixes
branch
from
ca76e48 to
c9e4149
Compare
Collaborator
Author
|
Apologies, just noticed there was a CI failure because of a couple more lints I didn't fix. Not sure why they didn't show up before, but should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before making another possible change, I tried running
just verify-allwhich revealed a bunch of failing lints. Many of these are because the repo usesclippy::pedantic.I attempted to stick to Conventional Commits, but as I'm not used to it please let me know if I missed the mark!
The only change to a public api among these commits (detected by cargo-public-api) is the change to
screen::Screen::formatted_lines_countqualifying it asconst.