forked from lammps/lammps
-
Notifications
You must be signed in to change notification settings - Fork 10
Rely on GPU pinning externally #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
WardLT
wants to merge
64
commits into
ACEsuit:mace
Choose a base branch
from
WardLT:mace-nompi
base: mace
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ghost explicitly, so unnecessary. This reverts commit 3bd488c.
Avoids the need to compile with MPI support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the need to compile with MPI support, which I needed to do when running many independent copies of LAMMPS per node in a workflow.
This change does not preclude running LAMMPS with MPI, but you will have to rely on setting
CUDA_VISIBLE_DEVICESfor each rank when launching LAMMPS (which is recommended mode at ALCF).I've marked this as a Draft for you to consider, noting that another PR to lammps-mace alters the GPU pinning in a different direction.