Add error handling while reading inputs

Author: adamgraham

Runtime/NavigationStack.cs

@@ -46,7 +46,7 @@ public class NavigationStack : MonoBehaviour
         /// off the stack.
         /// </summary>
         [Tooltip("The input button that handles backwards navigation by popping items off the stack.")]
-        public string backNavigationInputButton = "Cancel";
+        public string legacyBackNavigationInput = "Cancel";
         #endif
 
         /// <summary>
@@ -116,8 +116,17 @@ private void OnDisable()
         #if ENABLE_LEGACY_INPUT_MANAGER
         private void Update()
         {
-            if (Input.GetButtonDown(backNavigationInputButton)) {
-                Pop();
+            try
+            {
+                if (!string.IsNullOrEmpty(legacyBackNavigationInput) && Input.GetButtonDown(legacyBackNavigationInput)) {
+                    Pop();
+                }
+            }
+            catch
+            {
+                #if UNITY_EDITOR || DEVELOPMENT_BUILD
+                Debug.LogWarning($"[NavigationStack]: Input button '{legacyBackNavigationInput}' is not setup.\nDefine the input in the Input Manager settings accessed from the menu: Edit > Project Settings");
+                #endif
             }
         }
         #endif

Runtime/ScrollWithInput.cs

@@ -20,34 +20,26 @@ public class ScrollWithInput : MonoBehaviour
         /// </summary>
         public ScrollRect scrollRect { get; private set; }
 
-        /// <summary>
-        /// The direction to scroll the ScrollRect.
-        /// </summary>
-        [Tooltip("The direction to scroll the ScrollRect.")]
-        public ScrollDirection scrollDirection = ScrollDirection.Vertical;
-
         #if ENABLE_INPUT_SYSTEM
-
         /// <summary>
         /// The input action that handles scrolling.
         /// </summary>
         [Tooltip("The input action that handles scrolling.")]
         public InputAction scrollInput = new InputAction("ScrollInput", InputActionType.Value, null, null, null, "Vector2");
+        #endif
 
-        #elif ENABLE_LEGACY_INPUT_MANAGER
-
+        #if ENABLE_LEGACY_INPUT_MANAGER
         /// <summary>
-        /// The input axis that handles scrolling in the y-axis.
+        /// The legacy input axis that handles scrolling in the y-axis.
         /// </summary>
-        [Tooltip("The input axis that handles scrolling in the y-axis.")]
-        public string scrollInputAxisY = "";
+        [Tooltip("The legacy input axis that handles scrolling in the y-axis.")]
+        public string legacyScrollInputY = "";
 
         /// <summary>
-        /// The input axis that handles scrolling in the x-axis.
+        /// The legacy input axis that handles scrolling in the x-axis.
         /// </summary>
-        [Tooltip("The input axis that handles scrolling in the x-axis.")]
-        public string scrollInputAxisX = "";
-
+        [Tooltip("The legacy input axis that handles scrolling in the x-axis.")]
+        public string legacyScrollInputX = "";
         #endif
 
         /// <summary>
@@ -56,6 +48,12 @@ public class ScrollWithInput : MonoBehaviour
         [Tooltip("The sensitivity multiplier applied to the input.")]
         public float sensitivity = 1f;
 
+        /// <summary>
+        /// The direction to scroll the ScrollRect.
+        /// </summary>
+        [Tooltip("The direction to scroll the ScrollRect.")]
+        public ScrollDirection direction = ScrollDirection.Vertical;
+
         private void Awake()
         {
             scrollRect = GetComponent<ScrollRect>();
@@ -96,17 +94,19 @@ private void Update()
 
                 #if ENABLE_INPUT_SYSTEM
                 input = scrollInput.ReadValue<Vector2>();
-                #elif ENABLE_LEGACY_INPUT_MANAGER
-                if (scrollInputAxisY != "") {
-                    input.y = Input.GetAxis(scrollInputAxisY);
+                #endif
+
+                #if ENABLE_LEGACY_INPUT_MANAGER
+                if (input.y == 0f) {
+                    input.y = GetAxis(legacyScrollInputX);
                 }
 
-                if (scrollInputAxisX != "") {
-                    input.x = Input.GetAxis(scrollInputAxisX);
+                if (input.x == 0f) {
+                    input.x = GetAxis(legacyScrollInputY);
                 }
                 #endif
 
-                switch (scrollDirection)
+                switch (direction)
                 {
                     case ScrollDirection.Vertical:
                         input.x = 0f;
@@ -121,6 +121,28 @@ private void Update()
             }
         }
 
+        #if ENABLE_LEGACY_INPUT_MANAGER
+        private float GetAxis(string inputName)
+        {
+            float value = 0f;
+
+            try
+            {
+                if (!string.IsNullOrEmpty(inputName)) {
+                    value = Input.GetAxis(inputName);
+                }
+            }
+            catch
+            {
+                #if UNITY_EDITOR || DEVELOPMENT_BUILD
+                Debug.LogWarning($"[ScrollWithInput]: Input axis '{inputName}' is not setup.\nDefine the input in the Input Manager settings accessed from the menu: Edit > Project Settings");
+                #endif
+            }
+
+            return value;
+        }
+        #endif
+
     }
 
 }