Skip to content

Commit a9c37d9

Browse files
fix: rename VirtualTable to PaginatedTable, remove old hooks (#995)
1 parent 5e4b3d4 commit a9c37d9

40 files changed

+112
-189
lines changed

src/components/NodeHostWrapper/NodeHostWrapper.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
}
99

1010
.data-table__row:hover,
11-
.ydb-virtual-table__row:hover {
11+
.ydb-paginated-table__row:hover {
1212
.ydb-node-host-wrapper__external-button {
1313
display: inline-flex;
1414
}

src/components/VirtualTable/VirtualTable.scss renamed to src/components/PaginatedTable/PaginatedTable.scss

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
@import '../../styles/mixins.scss';
22

3-
.ydb-virtual-table {
3+
.ydb-paginated-table {
44
$block: &;
5-
$cell-border: 1px solid var(--virtual-table-border-color);
6-
--virtual-table-cell-vertical-padding: 5px;
7-
--virtual-table-cell-horizontal-padding: 10px;
5+
$cell-border: 1px solid var(--paginated-table-border-color);
6+
--paginated-table-cell-vertical-padding: 5px;
7+
--paginated-table-cell-horizontal-padding: 10px;
88

9-
--virtual-table-border-color: var(--g-color-base-generic-hover);
10-
--virtual-table-hover-color: var(--g-color-base-float-hover);
9+
--paginated-table-border-color: var(--g-color-base-generic-hover);
10+
--paginated-table-hover-color: var(--g-color-base-float-hover);
1111

1212
width: 100%;
1313
@include body-2-typography();
@@ -27,7 +27,7 @@
2727

2828
&__row {
2929
&:hover {
30-
background: var(--virtual-table-hover-color);
30+
background: var(--paginated-table-hover-color);
3131
}
3232

3333
&_empty {
@@ -75,8 +75,8 @@
7575

7676
width: 100%;
7777
max-width: 100%;
78-
padding: var(--virtual-table-cell-vertical-padding)
79-
var(--virtual-table-cell-horizontal-padding);
78+
padding: var(--paginated-table-cell-vertical-padding)
79+
var(--paginated-table-cell-horizontal-padding);
8080

8181
&_align {
8282
&_left {
@@ -122,8 +122,8 @@
122122

123123
width: 100%;
124124
max-width: 100%;
125-
padding: var(--virtual-table-cell-vertical-padding)
126-
var(--virtual-table-cell-horizontal-padding);
125+
padding: var(--paginated-table-cell-vertical-padding)
126+
var(--paginated-table-cell-horizontal-padding);
127127

128128
vertical-align: middle;
129129
white-space: nowrap;

src/components/VirtualTable/VirtualTable.tsx renamed to src/components/PaginatedTable/PaginatedTable.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {EmptyTableRow} from './TableRow';
1111
import {DEFAULT_REQUEST_TIMEOUT, DEFAULT_TABLE_ROW_HEIGHT} from './constants';
1212
import i18n from './i18n';
1313
import {
14-
createVirtualTableReducer,
14+
createPaginatedTableReducer,
1515
initChunk,
1616
removeChunk,
1717
resetChunks,
@@ -35,9 +35,9 @@ import type {
3535
} from './types';
3636
import {useIntersectionObserver} from './useIntersectionObserver';
3737

38-
import './VirtualTable.scss';
38+
import './PaginatedTable.scss';
3939

40-
export interface VirtualTableProps<T> {
40+
export interface PaginatedTableProps<T> {
4141
limit: number;
4242
fetchData: FetchData<T>;
4343
columns: Column<T>[];
@@ -54,7 +54,7 @@ export interface VirtualTableProps<T> {
5454
dependencyArray?: unknown[]; // Fully reload table on params change
5555
}
5656

57-
export const VirtualTable = <T,>({
57+
export const PaginatedTable = <T,>({
5858
limit,
5959
fetchData,
6060
columns,
@@ -67,11 +67,11 @@ export const VirtualTable = <T,>({
6767
renderEmptyDataMessage,
6868
renderErrorMessage,
6969
dependencyArray,
70-
}: VirtualTableProps<T>) => {
70+
}: PaginatedTableProps<T>) => {
7171
const inited = React.useRef(false);
7272
const tableContainer = React.useRef<HTMLDivElement>(null);
7373

74-
const [state, dispatch] = React.useReducer(createVirtualTableReducer<T>(), {});
74+
const [state, dispatch] = React.useReducer(createPaginatedTableReducer<T>(), {});
7575

7676
const [sortParams, setSortParams] = React.useState<SortParams | undefined>(initialSortParams);
7777

File renamed without changes.

src/components/VirtualTable/ResizeableVirtualTable.tsx renamed to src/components/PaginatedTable/ResizeablePaginatedTable.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import type {ColumnWidthByName} from '@gravity-ui/react-data-table';
22

33
import {useTableResize} from '../../utils/hooks/useTableResize';
44

5-
import type {VirtualTableProps} from './VirtualTable';
6-
import {VirtualTable} from './VirtualTable';
5+
import type {PaginatedTableProps} from './PaginatedTable';
6+
import {PaginatedTable} from './PaginatedTable';
77
import type {Column} from './types';
88

99
function updateColumnsWidth<T>(columns: Column<T>[], columnsWidthSetup: ColumnWidthByName) {
@@ -12,20 +12,24 @@ function updateColumnsWidth<T>(columns: Column<T>[], columnsWidthSetup: ColumnWi
1212
});
1313
}
1414

15-
interface ResizeableVirtualTableProps<T> extends Omit<VirtualTableProps<T>, 'onColumnsResize'> {
15+
interface ResizeablePaginatedTableProps<T> extends Omit<PaginatedTableProps<T>, 'onColumnsResize'> {
1616
columnsWidthLSKey: string;
1717
}
1818

19-
export function ResizeableVirtualTable<T>({
19+
export function ResizeablePaginatedTable<T>({
2020
columnsWidthLSKey,
2121
columns,
2222
...props
23-
}: ResizeableVirtualTableProps<T>) {
23+
}: ResizeablePaginatedTableProps<T>) {
2424
const [tableColumnsWidth, setTableColumnsWidth] = useTableResize(columnsWidthLSKey);
2525

2626
const updatedColumns = updateColumnsWidth(columns, tableColumnsWidth);
2727

2828
return (
29-
<VirtualTable columns={updatedColumns} onColumnsResize={setTableColumnsWidth} {...props} />
29+
<PaginatedTable
30+
columns={updatedColumns}
31+
onColumnsResize={setTableColumnsWidth}
32+
{...props}
33+
/>
3034
);
3135
}
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)