Skip to content

Commit 62de3e6

Browse files
authored
fix: use-QueryService-by-default-for-running-queries-1171 (#1188)
1 parent ab3528b commit 62de3e6

File tree

6 files changed

+11
-10
lines changed

6 files changed

+11
-10
lines changed

src/containers/Tenant/Query/QueryEditorControls/utils/getChangedQueryExecutionSettings.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
} from '../../../../../utils/query';
88

99
const DEFAULT_QUERY_SETTINGS: QuerySettings = {
10-
queryMode: QUERY_MODES.script,
10+
queryMode: QUERY_MODES.query,
1111
isolationLevel: ISOLATION_LEVELS.serializable,
1212
timeout: '60',
1313
statisticsMode: STATISTICS_MODES.none,

src/containers/Tenant/Query/QueryEditorControls/utils/getChangedQueryExecutionSettingsDescription.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {QUERY_SETTINGS_FIELD_SETTINGS} from '../../QuerySettingsDialog/constants
1414
import getChangedQueryExecutionSettingsDescription from './getChangedQueryExecutionSettingsDescription';
1515

1616
const DEFAULT_QUERY_SETTINGS: QuerySettings = {
17-
queryMode: QUERY_MODES.script,
17+
queryMode: QUERY_MODES.query,
1818
isolationLevel: ISOLATION_LEVELS.serializable,
1919
timeout: '60',
2020
statisticsMode: STATISTICS_MODES.none,

src/containers/Tenant/Query/QuerySettingsDialog/constants.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,16 @@ export const ISOLATION_LEVEL_SELECT_OPTIONS = [
3737
];
3838

3939
export const QUERY_MODE_SELECT_OPTIONS = [
40+
{
41+
value: QUERY_MODES.query,
42+
content: QUERY_MODES_TITLES[QUERY_MODES.query],
43+
text: i18n('method-description.query'),
44+
isDefault: true,
45+
},
4046
{
4147
value: QUERY_MODES.script,
4248
content: QUERY_MODES_TITLES[QUERY_MODES.script],
4349
text: i18n('method-description.script'),
44-
isDefault: true,
4550
},
4651
{
4752
value: QUERY_MODES.scan,
@@ -53,11 +58,6 @@ export const QUERY_MODE_SELECT_OPTIONS = [
5358
content: QUERY_MODES_TITLES[QUERY_MODES.data],
5459
text: i18n('method-description.data'),
5560
},
56-
{
57-
value: QUERY_MODES.query,
58-
content: QUERY_MODES_TITLES[QUERY_MODES.query],
59-
text: i18n('method-description.query'),
60-
},
6161
{
6262
value: QUERY_MODES.pg,
6363
content: QUERY_MODES_TITLES[QUERY_MODES.pg],

src/utils/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export const TENANT_OVERVIEW_TABLES_SETTINGS = {
124124
} as const;
125125

126126
export const DEFAULT_QUERY_SETTINGS = {
127-
queryMode: QUERY_MODES.script,
127+
queryMode: QUERY_MODES.query,
128128
isolationLevel: ISOLATION_LEVELS.serializable,
129129
timeout: '60',
130130
statisticsMode: STATISTICS_MODES.none,

tests/suites/tenant/queryEditor/QueryEditor.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ export const VISIBILITY_TIMEOUT = 5000;
44

55
export enum QueryMode {
66
YQLScript = 'YQL Script',
7+
Data = 'DML',
78
Scan = 'Scan',
89
}
910

tests/suites/tenant/queryEditor/queryEditor.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ test.describe('Test Query Editor', async () => {
278278
// Test for Execute mode
279279
await queryEditor.setQuery(longRunningQuery);
280280
await queryEditor.clickGearButton();
281-
await queryEditor.settingsDialog.changeStatsLevel('Profile');
281+
await queryEditor.settingsDialog.changeQueryMode(QueryMode.Data);
282282
await queryEditor.settingsDialog.clickButton(ButtonNames.Save);
283283

284284
// Test for Explain mode

0 commit comments

Comments
 (0)