add eslint

Author: yyx990803

example/counter.html

@@ -10,7 +10,6 @@
   <!-- simple usage -->
   <button v-stream:click="plus$">Add on Click</button>
 
-
   <button v-stream:click="{ subject: plus$, data: minusDelta1, options:{once:true} }">Add on Click (Option once:true)</button>
 
   <!-- you can also stream to the same subject with different events/data -->
@@ -21,6 +20,8 @@
   </button>
 
   <pre>{{ $data }}</pre>
+
+  <my-button v-stream:click="plus$"></my-button>
 </div>
 
 <script>
@@ -34,6 +35,12 @@
     }
   },
 
+  components: {
+    myButton: {
+      template: '<button>MyButton</button>'
+    }
+  },
+
   created () {
     //Speed up mousemove minus delta after 5s
     setTimeout(() => {

package.json

@@ -24,18 +24,28 @@
   "scripts": {
     "dev": "rollup -c rollup.config.js -w",
     "build": "rollup -c rollup.config.js",
+    "lint": "eslint src test example --fix",
     "test": "jest",
     "dev:test": "jest --watch",
+    "prebuild": "npm run lint",
     "pretest": "npm run build",
     "prepublish": "npm run build"
   },
   "devDependencies": {
     "buble": "^0.15.2",
+    "eslint": "^3.0.0",
+    "eslint-plugin-vue-libs": "^1.2.0",
     "jest": "^19.0.2",
     "rollup": "^0.41.6",
     "rollup-plugin-buble": "^0.15.0",
     "rollup-watch": "^3.2.2",
     "rxjs": "^5.2.0",
     "vue": "^2.2.4"
+  },
+  "eslintConfig": {
+    "root": true,
+    "extends": [
+      "plugin:vue-libs/recommended"
+    ]
   }
 }

src/directives/stream.js

@@ -43,7 +43,7 @@ export default {
         )
         return
       }
-      let fromEventArgs = handle.options ? [el, event, handle.options] : [el, event]
+      const fromEventArgs = handle.options ? [el, event, handle.options] : [el, event]
       handle.subscription = Rx.Observable.fromEvent(...fromEventArgs).subscribe(e => {
         next({
           event: e,

src/index.js

@@ -1,3 +1,5 @@
+/* global Vue, Rx */
+
 import { install } from './util'
 import rxMixin from './mixin'
 import streamDirective from './directives/stream'

src/methods/eventToObservable.js

@@ -10,12 +10,12 @@ export default function eventToObservable (evtName) {
     return
   }
   const vm = this
-  let evtNames = Array.isArray(evtName) ? evtName : [evtName]
+  const evtNames = Array.isArray(evtName) ? evtName : [evtName]
   const obs$ = Rx.Observable.create(observer => {
-    let eventPairs = evtNames.map(name => {
-      let callback = msg => observer.next({name, msg})
+    const eventPairs = evtNames.map(name => {
+      const callback = msg => observer.next({ name, msg })
       vm.$on(name, callback)
-      return {name, callback}
+      return { name, callback }
     })
     return () => {
       // Only remove the specific callback

test/test.js

@@ -1,14 +1,17 @@
+/* eslint-env jest */
+
 'use strict'
+
 const Vue = require('vue/dist/vue.js')
 const VueRx = require('../dist/vue-rx.js')
 
-//library
+// library
 const Observable = require('rxjs/Observable').Observable
 const Subject = require('rxjs/Subject').Subject
 const Subscription = require('rxjs/Subscription').Subscription
 require('rxjs/add/observable/fromEvent')
 
-//user
+// user
 require('rxjs/add/operator/map')
 require('rxjs/add/operator/startWith')
 require('rxjs/add/operator/scan')
@@ -88,7 +91,7 @@ test('bind subscriptions to render', done => {
 })
 
 test('subscriptions() has access to component state', () => {
-  const { ob, next } = mock()
+  const { ob } = mock()
 
   const vm = new Vue({
     data: {
@@ -112,8 +115,6 @@ test('subscriptions() has access to component state', () => {
 })
 
 test('v-stream directive (basic)', done => {
-  const { ob, next } = mock()
-
   const vm = new Vue({
     template: `
       <div>
@@ -128,7 +129,7 @@ test('v-stream directive (basic)', done => {
           .startWith(0)
           .scan((total, change) => total + change)
       }
-    },
+    }
   }).$mount()
 
   expect(vm.$el.querySelector('span').textContent).toBe('0')
@@ -140,8 +141,6 @@ test('v-stream directive (basic)', done => {
 })
 
 test('v-stream directive (with data)', done => {
-  const { ob, next } = mock()
-
   const vm = new Vue({
     data: {
       delta: -1
@@ -159,7 +158,7 @@ test('v-stream directive (with data)', done => {
           .startWith(0)
           .scan((total, change) => total + change)
       }
-    },
+    }
   }).$mount()
 
   expect(vm.$el.querySelector('span').textContent).toBe('0')
@@ -178,8 +177,6 @@ test('v-stream directive (with data)', done => {
 })
 
 test('v-stream directive (multiple bindings on same node)', done => {
-  const { ob, next } = mock()
-
   const vm = new Vue({
     template: `
       <div>
@@ -196,7 +193,7 @@ test('v-stream directive (multiple bindings on same node)', done => {
           .startWith(0)
           .scan((total, change) => total + change)
       }
-    },
+    }
   }).$mount()
 
   expect(vm.$el.querySelector('span').textContent).toBe('0')
@@ -212,8 +209,6 @@ test('v-stream directive (multiple bindings on same node)', done => {
 })
 
 test('$fromDOMEvent()', done => {
-  const { ob, next } = mock()
-
   const vm = new Vue({
     template: `
       <div>
@@ -285,41 +280,39 @@ test('$subscribeTo()', () => {
   expect(results).toEqual([1]) // should not trigger anymore
 })
 
-
 test('$eventToObservable()', done => {
-  let calls = 0;
+  let calls = 0
   const vm = new Vue({
-    created(){
-      let ob = this.$eventToObservable('ping')
+    created () {
+      this.$eventToObservable('ping')
         .subscribe(function (event) {
-          expect(event.name).toEqual('ping');
-          expect(event.msg).toEqual('ping message');
+          expect(event.name).toEqual('ping')
+          expect(event.msg).toEqual('ping message')
           calls++
-        });
+        })
     }
-  });
-  vm.$emit('ping','ping message');
-
-  nextTick(()=>{
-    vm.$destroy();
-    //Should not emit
-    vm.$emit('pong','pong message');
-    expect(calls).toEqual(1);
-    done()
-  });
-});
+  })
+  vm.$emit('ping', 'ping message')
 
+  nextTick(() => {
+    vm.$destroy()
+    // Should not emit
+    vm.$emit('pong', 'pong message')
+    expect(calls).toEqual(1)
+    done()
+  })
+})
 
 test('$eventToObservable() with lifecycle hooks', done => {
   const vm = new Vue({
-    created(){
+    created () {
       this.$eventToObservable('hook:beforeDestroy')
         .subscribe(function (event) {
           done(event)
-        });
+        })
     }
-  });
-  nextTick(()=>{
+  })
+  nextTick(() => {
     vm.$destroy()
   })
-});
+})