-
Notifications
You must be signed in to change notification settings - Fork 47
Open
Description
Apologies for the bikeshed, but I have a few comments about the API that might be worth considering before a 1.0 release:
- When a trait represents an action, it is generally named imperatively (
Display,Read,Write,Hash, etc.). For least surprise,UnicodeNormalizationcould be namedUnicodeNormalizeinstead, or perhaps evenNormalize, to avoid repeating the module name. - The method names
nfd,nfkd,nfc, andnfkchave no intrinsic meaning, which makes it hard to know what they do in isolation, outside of the context of theUnicodeNormalizationdocs. Even for a person who is aware of the concept of Unicode normalization, it might not be clear what a line likelet c = s.nfc().collect::<String>();does, without first having seen the documentation, or an explanatory comment. Something likenormalize_form_cwould at least suggest that some kind of normalization is going on.
remram44, Florian-Schoenherr, U007D, wiiznokes and swfsql
Metadata
Metadata
Assignees
Labels
No labels