Commit c3c08ac
committed
Adjust modal widths globally
- Set width to 100% (mobile first approach)
- Set max-width to 39rem
- This is based on Figma designs for report package modal, but looks
like a pretty good default value for other modals as well
- If needed, modals can override this value with local CSS, like is
done for login button modal
- Set max-width to 15rem. The value is selected totally arbitrarily.
The intent is for the modal to break less on very narrow screens. We
might want to rethink the modal implementation from mobile first
perspective separately, to e.g. have less padding on mobile where the
screen estate is limited
- How well these changes work on modals on package wiki page couldn't
be confirmed as the feature is currently very much broken1 parent 6e2d678 commit c3c08ac
File tree
4 files changed
+9
-2
lines changed- apps/cyberstorm-remix/app
- p/components/ReportPackage
- packages/cyberstorm/src/newComponents/Modal
4 files changed
+9
-2
lines changedLines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
137 | 141 | | |
138 | 142 | | |
139 | 143 | | |
140 | 144 | | |
141 | 145 | | |
142 | | - | |
143 | 146 | | |
144 | 147 | | |
145 | 148 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
| 249 | + | |
249 | 250 | | |
250 | 251 | | |
251 | 252 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
| |||
0 commit comments