Skip to content

Commit a25273f

Browse files
authored
Merge pull request #1652 from thunderstore-io/12-03-add_error_handling_and_display_for_addmemberform
Add error handling and display for AddMemberForm
2 parents 8fac767 + 41ca066 commit a25273f

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/MemberAddForm.tsx

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export function MemberAddForm(props: {
3131
}) {
3232
const toast = useToast();
3333
const [open, setOpen] = useState(false);
34+
const [error, setError] = useState<string | null>(null);
3435

3536
function formFieldUpdateAction(
3637
state: TeamAddMemberRequestData,
@@ -86,18 +87,21 @@ export function MemberAddForm(props: {
8687
setOpen(false);
8788
},
8889
onSubmitError: (error) => {
89-
toast.addToast({
90-
csVariant: "danger",
91-
children: `Error occurred: ${error.message || "Unknown error"}`,
92-
duration: 8000,
93-
});
90+
if (error.message.includes("400")) {
91+
setError("User not found, make sure you typed the name correctly");
92+
} else {
93+
setError("An unexpected error occurred, please try again later.");
94+
}
9495
},
9596
});
9697

9798
return (
9899
<Modal
99100
open={open}
100-
onOpenChange={setOpen}
101+
onOpenChange={(val) => {
102+
setOpen(val);
103+
if (!val) setError(null);
104+
}}
101105
titleContent="Add Team Member"
102106
csSize="small"
103107
trigger={
@@ -124,6 +128,7 @@ export function MemberAddForm(props: {
124128
placeholder={"Enter username..."}
125129
value={formInputs.username}
126130
onChange={(e) => {
131+
setError(null);
127132
updateFormFieldState({
128133
field: "username",
129134
value: e.target.value,
@@ -132,6 +137,7 @@ export function MemberAddForm(props: {
132137
rootClasses="add-member-form__username-input"
133138
id="username"
134139
/>
140+
{error && <div className="add-member-form__error">{error}</div>}
135141
</div>
136142
<div className="add-member-form__field">
137143
<label className="add-member-form__label" htmlFor="role">

apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/Members.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,12 @@
6262
}
6363
}
6464

65+
.add-member-form__error {
66+
margin-top: var(--space-2);
67+
color: var(--color-accent-red-7);
68+
font-size: var(--font-size-body-sm);
69+
}
70+
6571
.add-member-form__label {
6672
color: var(--color-text-tertiary);
6773
font-weight: var(--font-weight-bold);

0 commit comments

Comments
 (0)