packageEdit: DRY error handling code

Sentry logging isn't needed in UI component, it's handled by
entry.server.tsx on server and RouteErrorBoundary on client.

Author: anttimaki

apps/cyberstorm-remix/app/p/packageEdit.tsx

@@ -40,11 +40,13 @@ export const meta: MetaFunction<typeof loader> = ({ data }) => {
   ];
 };
 
+const package404 = new Response("Package not found", { status: 404 });
+
 export async function loader({ params }: LoaderFunctionArgs) {
   const { communityId, namespaceId, packageId } = params;
 
   if (!communityId || !namespaceId || !packageId) {
-    throw new Response("Package not found", { status: 404 });
+    throw package404;
   }
 
   try {
@@ -65,12 +67,7 @@ export async function loader({ params }: LoaderFunctionArgs) {
       permissions: undefined,
     };
   } catch (error) {
-    if (error instanceof ApiError) {
-      throw new Response("Package not found", { status: 404 });
-    } else {
-      // REMIX TODO: Add sentry
-      throw error;
-    }
+    throw error instanceof ApiError ? package404 : error;
   }
 }
 
@@ -79,7 +76,7 @@ export async function clientLoader({ params }: LoaderFunctionArgs) {
   const { communityId, namespaceId, packageId } = params;
 
   if (!communityId || !namespaceId || !packageId) {
-    throw new Response("Package not found", { status: 404 });
+    throw package404;
   }
 
   try {
@@ -116,11 +113,7 @@ export async function clientLoader({ params }: LoaderFunctionArgs) {
       permissions: permissions,
     };
   } catch (error) {
-    if (error instanceof ApiError) {
-      throw new Response("Package not found", { status: 404 });
-    } else {
-      throw error;
-    }
+    throw error instanceof ApiError ? package404 : error;
   }
 }