abstract: throw an error if failed to create a temp tube

The create_tube method returns a tube or throws an error in almost
all cases. It is unexpected that only in one case it returns nil
and writes an error message into a log.

The patch unifies the behavior of this method.

Author: oleg-jukovec

queue/abstract.lua

@@ -579,8 +579,7 @@ function method.create_tube(tube_name, tube_type, opts)
 
     local replicaset_mode = queue.cfg['in_replicaset'] or false
     if replicaset_mode and opts.temporary then
-        log.error("Cannot create temporary tube in replicaset mode")
-        return
+        error("Cannot create temporary tube in replicaset mode")
     end
 
     local driver = queue.driver[tube_type]

t/200-master-replica.t

@@ -21,7 +21,7 @@ end
 -- Replica connection handler.
 local conn = {}
 
-test:plan(7)
+test:plan(8)
 
 test:test('Check master-replica setup', function(test)
     test:plan(8)
@@ -46,6 +46,19 @@ test:test('Check master-replica setup', function(test)
     test:ok(tube, 'test tube created')
 end)
 
+test:test('Check error create temporary tube', function(test)
+    test:plan(2)
+    local engine = os.getenv('ENGINE') or 'memtx'
+
+    queue.cfg{ttr = 0.5, in_replicaset = true}
+    local opts = {temporary = true, engine = engine}
+    local status, err = pcall(queue.create_tube, 'test', 'fifo', opts)
+    test:is(status, false, 'test tube should not be created')
+    local founded = string.find(err,
+        'Cannot create temporary tube in replicaset mode')
+    test:ok(founded, 'unexpected error')
+end)
+
 test:test('Check queue state switching', function(test)
     test:plan(4)
     box.cfg{read_only = true}