Symfony 6.2 - remove extra call to check hasSession

a.dmitryuk · a.dmitryuk · commit f80637b56e73 · 2022-11-09T14:43:50.000+07:00
diff --git a/EventListener/SessionStrategyListener.php b/EventListener/SessionStrategyListener.php
@@ -39,7 +39,7 @@ public function onSuccessfulLogin(LoginSuccessEvent $event): void
         $request = $event->getRequest();
         $token = $event->getAuthenticatedToken();
 
-        if (!$request->hasSession() || !$request->hasPreviousSession()) {
+        if (!$request->hasPreviousSession()) {
             return;
         }
 
diff --git a/Firewall/ContextListener.php b/Firewall/ContextListener.php
@@ -87,7 +87,7 @@ public function authenticate(RequestEvent $event)
         }
 
         $request = $event->getRequest();
-        $session = $request->hasPreviousSession() && $request->hasSession() ? $request->getSession() : null;
+        $session = $request->hasPreviousSession() ? $request->getSession() : null;
 
         $request->attributes->set('_security_firewall_run', $this->sessionKey);
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function onSuccessfulLogin(LoginSuccessEvent $event): void`
`39`	`39`	`$request = $event->getRequest();`
`40`	`40`	`$token = $event->getAuthenticatedToken();`
`41`	`41`
`42`		`- if (!$request->hasSession() \|\| !$request->hasPreviousSession()) {`
	`42`	`+ if (!$request->hasPreviousSession()) {`
`43`	`43`	`return;`
`44`	`44`	`}`
`45`	`45`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ public function authenticate(RequestEvent $event)`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`$request = $event->getRequest();`
`90`		`- $session = $request->hasPreviousSession() && $request->hasSession() ? $request->getSession() : null;`
	`90`	`+ $session = $request->hasPreviousSession() ? $request->getSession() : null;`
`91`	`91`
`92`	`92`	`$request->attributes->set('_security_firewall_run', $this->sessionKey);`
`93`	`93`