[HttpFoundation] Deprecate HTTP method override for methods GET, HEAD, CONNECT and TRACE

Author: nicolas-grekas

Tests/Authenticator/AbstractLoginFormAuthenticatorTest.php

@@ -34,7 +34,7 @@ public static function provideSupportsData(): iterable
     {
         yield [
             '/login',
-            Request::create('http://localhost/login', Request::METHOD_POST, [], [], [], [
+            Request::create('http://localhost/login', 'POST', [], [], [], [
                 'DOCUMENT_ROOT' => '/var/www/app/public',
                 'PHP_SELF' => '/index.php',
                 'SCRIPT_FILENAME' => '/var/www/app/public/index.php',
@@ -44,7 +44,7 @@ public static function provideSupportsData(): iterable
         ];
         yield [
             '/login',
-            Request::create('http://localhost/somepath', Request::METHOD_POST, [], [], [], [
+            Request::create('http://localhost/somepath', 'POST', [], [], [], [
                 'DOCUMENT_ROOT' => '/var/www/app/public',
                 'PHP_SELF' => '/index.php',
                 'SCRIPT_FILENAME' => '/var/www/app/public/index.php',
@@ -54,7 +54,7 @@ public static function provideSupportsData(): iterable
         ];
         yield [
             '/folder/login',
-            Request::create('http://localhost/folder/login', Request::METHOD_POST, [], [], [], [
+            Request::create('http://localhost/folder/login', 'POST', [], [], [], [
                 'DOCUMENT_ROOT' => '/var/www/app/public',
                 'PHP_SELF' => '/folder/index.php',
                 'SCRIPT_FILENAME' => '/var/www/app/public/index.php',
@@ -64,7 +64,7 @@ public static function provideSupportsData(): iterable
         ];
         yield [
             '/folder/login',
-            Request::create('http://localhost/folder/somepath', Request::METHOD_POST, [], [], [], [
+            Request::create('http://localhost/folder/somepath', 'POST', [], [], [], [
                 'DOCUMENT_ROOT' => '/var/www/app/public',
                 'PHP_SELF' => '/folder/index.php',
                 'SCRIPT_FILENAME' => '/var/www/app/public/index.php',
@@ -74,7 +74,7 @@ public static function provideSupportsData(): iterable
         ];
         yield [
             '/index.php/login',
-            Request::create('http://localhost/index.php/login', Request::METHOD_POST, [], [], [], [
+            Request::create('http://localhost/index.php/login', 'POST', [], [], [], [
                 'DOCUMENT_ROOT' => '/var/www/app/public',
                 'PHP_SELF' => '/index.php',
                 'SCRIPT_FILENAME' => '/var/www/app/public/index.php',
@@ -84,7 +84,7 @@ public static function provideSupportsData(): iterable
         ];
         yield [
             '/index.php/login',
-            Request::create('http://localhost/index.php/somepath', Request::METHOD_POST, [], [], [], [
+            Request::create('http://localhost/index.php/somepath', 'POST', [], [], [], [
                 'DOCUMENT_ROOT' => '/var/www/app/public',
                 'PHP_SELF' => '/index.php',
                 'SCRIPT_FILENAME' => '/var/www/app/public/index.php',

Tests/Authenticator/AccessToken/FormEncodedBodyAccessTokenAuthenticatorTest.php

@@ -40,7 +40,7 @@ public function testSupport()
         $this->setUpAuthenticator();
         $request = new Request([], [], [], [], [], ['CONTENT_TYPE' => 'application/x-www-form-urlencoded']);
         $request->request->set('access_token', 'INVALID_ACCESS_TOKEN');
-        $request->setMethod(Request::METHOD_POST);
+        $request->setMethod('POST');
 
         $this->assertNull($this->authenticator->supports($request));
     }
@@ -50,7 +50,7 @@ public function testSupportsWithCustomParameter()
         $this->setUpAuthenticator('protection-token');
         $request = new Request([], [], [], [], [], ['CONTENT_TYPE' => 'application/x-www-form-urlencoded']);
         $request->request->set('protection-token', 'INVALID_ACCESS_TOKEN');
-        $request->setMethod(Request::METHOD_POST);
+        $request->setMethod('POST');
 
         $this->assertNull($this->authenticator->supports($request));
     }
@@ -61,7 +61,7 @@ public function testAuthenticate()
         $this->setUpAuthenticator();
         $request = new Request([], [], [], [], [], ['CONTENT_TYPE' => 'application/x-www-form-urlencoded'], 'access_token=VALID_ACCESS_TOKEN');
         $request->request->set('access_token', 'VALID_ACCESS_TOKEN');
-        $request->setMethod(Request::METHOD_POST);
+        $request->setMethod('POST');
 
         $passport = $this->authenticator->authenticate($request);
         $this->assertInstanceOf(SelfValidatingPassport::class, $passport);
@@ -73,7 +73,7 @@ public function testAuthenticateWithCustomParameter()
         $this->setUpAuthenticator('protection-token');
         $request = new Request([], [], [], [], [], ['CONTENT_TYPE' => 'application/x-www-form-urlencoded']);
         $request->request->set('protection-token', 'VALID_ACCESS_TOKEN');
-        $request->setMethod(Request::METHOD_POST);
+        $request->setMethod('POST');
 
         $passport = $this->authenticator->authenticate($request);
         $this->assertInstanceOf(SelfValidatingPassport::class, $passport);
@@ -93,24 +93,24 @@ public function testAuthenticateInvalid(Request $request, string $errorMessage,
     public static function provideInvalidAuthenticateData(): iterable
     {
         $request = new Request();
-        $request->setMethod(Request::METHOD_GET);
+        $request->setMethod('GET');
         yield [$request, 'Invalid credentials.', BadCredentialsException::class];
 
         $request = new Request();
-        $request->setMethod(Request::METHOD_POST);
+        $request->setMethod('POST');
         yield [$request, 'Invalid credentials.', BadCredentialsException::class];
 
         $request = new Request([], [], [], [], [], ['HTTP_AUTHORIZATION' => 'Bearer VALID_ACCESS_TOKEN']);
-        $request->setMethod(Request::METHOD_POST);
+        $request->setMethod('POST');
         yield [$request, 'Invalid credentials.', BadCredentialsException::class];
 
         $request = new Request();
-        $request->setMethod(Request::METHOD_POST);
+        $request->setMethod('POST');
         $request->request->set('foo', 'VALID_ACCESS_TOKEN');
         yield [$request, 'Invalid credentials.', BadCredentialsException::class];
 
         $request = new Request([], [], [], [], [], ['CONTENT_TYPE' => 'application/x-www-form-urlencoded']);
-        $request->setMethod(Request::METHOD_POST);
+        $request->setMethod('POST');
         $request->request->set('access_token', 'INVALID_ACCESS_TOKEN');
         yield [$request, 'Invalid access token or invalid user.', BadCredentialsException::class];
     }