remove legacy tests

Author: xabbuh

CHANGELOG.md

@@ -4,6 +4,31 @@ CHANGELOG
 8.0
 ---
 
+ * When extending the `RememberMeDetails` class and overriding its constructor, the `$userFqcn` parameter has to be removed from its signature:
+
+   Before:
+
+   ```php
+   class CustomRememberMeDetails extends RememberMeDetails
+   {
+       public function __construct(string $userFqcn, string $userIdentifier, int $expires, string $value)
+       {
+           parent::__construct($userFqcn, $userIdentifier, $expires, $value);
+       }
+   }
+   ```
+
+   After:
+
+   ```php
+   class CustomRememberMeDetails extends RememberMeDetails
+   {
+       public function __construct(string $userIdentifier, int $expires, string $value)
+       {
+           parent::__construct($userIdentifier, $expires, $value);
+       }
+   }
+   ```
  * Remove `RememberMeDetails::getUserFqcn()`
  * Remove callable firewall listeners support, extend `AbstractListener` or implement `FirewallListenerInterface` instead
  * Remove `AbstractListener::__invoke`

Tests/Authenticator/RememberMeAuthenticatorTest.php

@@ -79,7 +79,7 @@ public function testAuthenticate()
     public function testAuthenticateLegacyCookieFormat()
     {
         $rememberMeDetails = new RememberMeDetails('wouter', 1, 'secret');
-        $request = Request::create('/', 'GET', [], ['_remember_me_cookie' => $rememberMeDetails->toString()]);
+        $request = Request::create('/', 'GET', [], ['_remember_me_cookie' => strtr(InMemoryUser::class, '\\', '.').$rememberMeDetails->toString()]);
         $passport = $this->authenticator->authenticate($request);
 
         $this->rememberMeHandler->expects($this->once())->method('consumeRememberMeCookie')->with($this->callback(fn ($arg) => $rememberMeDetails == $arg));

Tests/RememberMe/PersistentRememberMeHandlerTest.php

@@ -274,7 +274,7 @@ public function testBase64EncodedTokensLegacyFormat()
         $this->tokenProvider->expects($this->once())->method('updateToken')->with('series1');
 
         $rememberMeDetails = new RememberMeDetails('wouter', 360, 'series1:tokenvalue');
-        $rememberMeDetails = RememberMeDetails::fromRawCookie(base64_encode($rememberMeDetails->toString()));
+        $rememberMeDetails = RememberMeDetails::fromRawCookie(base64_encode(strtr(InMemoryUser::class, '\\', '.').$rememberMeDetails->toString()));
         $this->handler->consumeRememberMeCookie($rememberMeDetails);
     }
 }

Tests/RememberMe/RememberMeDetailsTest.php

@@ -40,20 +40,6 @@ public function testFromRawCookieChildClassWithNewConstructorSignature()
         $this->assertSame('series1:token_value', $rememberMeDetails->getValue());
     }
 
-    #[Group('legacy')]
-    #[IgnoreDeprecations]
-    public function testFromRawCookieChildClassWithLegacyConstructorSignature()
-    {
-        $this->expectUserDeprecationMessage(\sprintf('Since symfony/security-http 7.4: Extending the "%s" class and overriding the constructor with four required arguments is deprecated. Change the constructor signature to __construct(string $userIdentifier, int $expires, string $value).', RememberMeDetails::class));
-
-        $rememberMeDetails = RememberMeDetailsChildLegacyConstructorSignature::fromRawCookie(self::getRememberMeCookieValue());
-
-        $this->assertSame(RememberMeDetailsChildLegacyConstructorSignature::class, $rememberMeDetails::class);
-        $this->assertSame('wouter', $rememberMeDetails->getUserIdentifier());
-        $this->assertSame(360, $rememberMeDetails->getExpires());
-        $this->assertSame('series1:token_value', $rememberMeDetails->getValue());
-    }
-
     public function testFromRawCookieChildClassWithoutConstructor()
     {
         $rememberMeDetails = RememberMeDetailsChildWithoutConstructor::fromRawCookie(self::getRememberMeCookieValue());
@@ -71,7 +57,6 @@ public function testFromLegacyRawCookie()
         $rememberMeDetails = RememberMeDetails::fromRawCookie(self::getLegacyRememberMeCookieValue());
 
         $this->assertSame(RememberMeDetails::class, $rememberMeDetails::class);
-        $this->assertSame(InMemoryUser::class, $rememberMeDetails->getUserFqcn());
         $this->assertSame('wouter', $rememberMeDetails->getUserIdentifier());
         $this->assertSame(360, $rememberMeDetails->getExpires());
         $this->assertSame('series1:token_value', $rememberMeDetails->getValue());
@@ -84,22 +69,6 @@ public function testFromLegacyRawCookieChildClassWithNewConstructorSignature()
         $rememberMeDetails = RememberMeDetailsChild::fromRawCookie(self::getLegacyRememberMeCookieValue());
 
         $this->assertSame(RememberMeDetailsChild::class, $rememberMeDetails::class);
-        $this->assertSame('', $rememberMeDetails->getUserFqcn());
-        $this->assertSame('wouter', $rememberMeDetails->getUserIdentifier());
-        $this->assertSame(360, $rememberMeDetails->getExpires());
-        $this->assertSame('series1:token_value', $rememberMeDetails->getValue());
-    }
-
-    #[Group('legacy')]
-    #[IgnoreDeprecations]
-    public function testFromLegacyRawCookieChildClassWithLegacyConstructorSignature()
-    {
-        $this->expectUserDeprecationMessage(\sprintf('Since symfony/security-http 7.4: Extending the "%s" class and overriding the constructor with four required arguments is deprecated. Change the constructor signature to __construct(string $userIdentifier, int $expires, string $value).', RememberMeDetails::class));
-
-        $rememberMeDetails = RememberMeDetailsChildLegacyConstructorSignature::fromRawCookie(self::getLegacyRememberMeCookieValue());
-
-        $this->assertSame(RememberMeDetailsChildLegacyConstructorSignature::class, $rememberMeDetails::class);
-        $this->assertSame(InMemoryUser::class, $rememberMeDetails->getUserFqcn());
         $this->assertSame('wouter', $rememberMeDetails->getUserIdentifier());
         $this->assertSame(360, $rememberMeDetails->getExpires());
         $this->assertSame('series1:token_value', $rememberMeDetails->getValue());
@@ -112,7 +81,6 @@ public function testFromLegacyRawCookieChildClassWithoutConstructor()
         $rememberMeDetails = RememberMeDetailsChildWithoutConstructor::fromRawCookie(self::getLegacyRememberMeCookieValue());
 
         $this->assertSame(RememberMeDetailsChildWithoutConstructor::class, $rememberMeDetails::class);
-        $this->assertSame(InMemoryUser::class, $rememberMeDetails->getUserFqcn());
         $this->assertSame('wouter', $rememberMeDetails->getUserIdentifier());
         $this->assertSame(360, $rememberMeDetails->getExpires());
         $this->assertSame('series1:token_value', $rememberMeDetails->getValue());
@@ -150,26 +118,6 @@ public function testFromPersistentTokenChildClassWithNewConstructorSignature()
         $this->assertSame('series1:token_value', $rememberMeDetails->getValue());
     }
 
-    #[Group('legacy')]
-    #[IgnoreDeprecations]
-    public function testFromPersistentTokenChildClassWithLegacyConstructorSignature()
-    {
-        $this->expectUserDeprecationMessage(\sprintf('Since symfony/security-http 7.4: Extending the "%s" class and overriding the constructor with four required arguments is deprecated. Change the constructor signature to __construct(string $userIdentifier, int $expires, string $value).', RememberMeDetails::class));
-
-        if (method_exists(PersistentToken::class, 'getClass')) {
-            $token = new PersistentToken(InMemoryUser::class, 'wouter', 'series1', 'token_value', new \DateTimeImmutable(), false);
-        } else {
-            $token = new PersistentToken('wouter', 'series1', 'token_value', new \DateTimeImmutable());
-        }
-
-        $rememberMeDetails = RememberMeDetailsChildLegacyConstructorSignature::fromPersistentToken($token, 360);
-
-        $this->assertSame(RememberMeDetailsChildLegacyConstructorSignature::class, $rememberMeDetails::class);
-        $this->assertSame('wouter', $rememberMeDetails->getUserIdentifier());
-        $this->assertSame(360, $rememberMeDetails->getExpires());
-        $this->assertSame('series1:token_value', $rememberMeDetails->getValue());
-    }
-
     public function testFromPersistentTokenChildClassWithoutConstructor()
     {
         if (method_exists(PersistentToken::class, 'getClass')) {
@@ -193,7 +141,7 @@ private static function getRememberMeCookieValue(): string
 
     private static function getLegacyRememberMeCookieValue(): string
     {
-        return base64_encode((new RememberMeDetails(InMemoryUser::class, 'wouter', 360, 'series1:token_value', false))->toString());
+        return base64_encode(strtr(InMemoryUser::class, '\\', '.').(new RememberMeDetails('wouter', 360, 'series1:token_value'))->toString());
     }
 }
 
@@ -205,14 +153,6 @@ public function __construct(string $userIdentifier, int $expires, string $value)
     }
 }
 
-class RememberMeDetailsChildLegacyConstructorSignature extends RememberMeDetails
-{
-    public function __construct(string $userFqcn, string $userIdentifier, int $expires, string $value)
-    {
-        parent::__construct($userFqcn, $userIdentifier, $expires, $value);
-    }
-}
-
 class RememberMeDetailsChildWithoutConstructor extends RememberMeDetails
 {
 }