Fix inconsistent return points.

Author: derrabus

Firewall/ExceptionListener.php

@@ -90,11 +90,21 @@ public function onKernelException(GetResponseForExceptionEvent $event)
         $exception = $event->getException();
         do {
             if ($exception instanceof AuthenticationException) {
-                return $this->handleAuthenticationException($event, $exception);
-            } elseif ($exception instanceof AccessDeniedException) {
-                return $this->handleAccessDeniedException($event, $exception);
-            } elseif ($exception instanceof LogoutException) {
-                return $this->handleLogoutException($exception);
+                $this->handleAuthenticationException($event, $exception);
+
+                return;
+            }
+
+            if ($exception instanceof AccessDeniedException) {
+                $this->handleAccessDeniedException($event, $exception);
+
+                return;
+            }
+
+            if ($exception instanceof LogoutException) {
+                $this->handleLogoutException($exception);
+
+                return;
             }
         } while (null !== $exception = $exception->getPrevious());
     }

Firewall/UsernamePasswordJsonAuthenticationListener.php

@@ -135,6 +135,9 @@ public function handle(GetResponseEvent $event)
         $event->setResponse($response);
     }
 
+    /**
+     * @return Response|null
+     */
     private function onSuccess(Request $request, TokenInterface $token)
     {
         if (null !== $this->logger) {
@@ -151,7 +154,7 @@ private function onSuccess(Request $request, TokenInterface $token)
         }
 
         if (!$this->successHandler) {
-            return; // let the original request succeeds
+            return null; // let the original request succeeds
         }
 
         $response = $this->successHandler->onAuthenticationSuccess($request, $token);

RememberMe/AbstractRememberMeServices.php

@@ -148,6 +148,8 @@ final public function autoLogin(Request $request)
 
             throw $e;
         }
+
+        return null;
     }
 
     /**