Merge branch '5.4' into 6.2

* 5.4:
  Migrate to `static` data providers using `rector/rector`

Author: nicolas-grekas

Tests/Authentication/AuthenticatorManagerTest.php

@@ -119,7 +119,7 @@ public function testAuthenticateRequest($matchingAuthenticatorIndex)
         $this->assertTrue($listenerCalled, 'The CheckPassportEvent listener is not called');
     }
 
-    public function provideMatchingAuthenticatorIndex()
+    public static function provideMatchingAuthenticatorIndex()
     {
         yield [0];
         yield [1];
@@ -189,7 +189,7 @@ public function testEraseCredentials($eraseCredentials)
         $manager->authenticateRequest($this->request);
     }
 
-    public function provideEraseCredentialsData()
+    public static function provideEraseCredentialsData()
     {
         yield [true];
         yield [false];

Tests/Authenticator/AbstractLoginFormAuthenticatorTest.php

@@ -31,7 +31,7 @@ public function testSupports(string $loginUrl, Request $request, bool $expected)
         $this->assertSame($expected, $authenticator->supports($request));
     }
 
-    public function provideSupportsData(): iterable
+    public static function provideSupportsData(): iterable
     {
         yield [
             '/login',

Tests/Authenticator/FormLoginAuthenticatorTest.php

@@ -60,7 +60,7 @@ public function testHandleWhenUsernameLength($username, $ok)
         $this->authenticator->authenticate($request);
     }
 
-    public function provideUsernamesForLength()
+    public static function provideUsernamesForLength()
     {
         yield [str_repeat('x', UserBadge::MAX_USERNAME_LENGTH + 1), false];
         yield [str_repeat('x', UserBadge::MAX_USERNAME_LENGTH - 1), true];
@@ -126,7 +126,7 @@ public function testHandleNonStringUsernameWithToString($postOnly)
         $this->authenticator->authenticate($request);
     }
 
-    public function postOnlyDataProvider()
+    public static function postOnlyDataProvider()
     {
         yield [true];
         yield [false];
@@ -171,7 +171,7 @@ public function testSupportsFormOnly(string $contentType, bool $shouldSupport)
         $this->assertSame($shouldSupport, $this->authenticator->supports($request));
     }
 
-    public function provideContentTypes()
+    public static function provideContentTypes()
     {
         yield ['application/json', false];
         yield ['application/x-www-form-urlencoded', true];

Tests/Authenticator/HttpBasicAuthenticatorTest.php

@@ -67,7 +67,7 @@ public function testHttpBasicServerParametersMissing(array $serverParameters)
         $this->assertFalse($this->authenticator->supports($request));
     }
 
-    public function provideMissingHttpBasicServerParameters()
+    public static function provideMissingHttpBasicServerParameters()
     {
         return [
             [[]],

Tests/Authenticator/JsonLoginAuthenticatorTest.php

@@ -48,7 +48,7 @@ public function testSupport($request)
         $this->assertTrue($this->authenticator->supports($request));
     }
 
-    public function provideSupportData()
+    public static function provideSupportData()
     {
         yield [new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], '{"username": "dunglas", "password": "foo"}')];
 
@@ -67,7 +67,7 @@ public function testSupportsWithCheckPath($request, $result)
         $this->assertSame($result, $this->authenticator->supports($request));
     }
 
-    public function provideSupportsWithCheckPathData()
+    public static function provideSupportsWithCheckPathData()
     {
         yield [Request::create('/api/login', 'GET', [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']), true];
         yield [Request::create('/login', 'GET', [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']), false];
@@ -107,7 +107,7 @@ public function testAuthenticateInvalid($request, $errorMessage, $exceptionType
         $this->authenticator->authenticate($request);
     }
 
-    public function provideInvalidAuthenticateData()
+    public static function provideInvalidAuthenticateData()
     {
         $request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']);
         yield [$request, 'Invalid JSON.'];

Tests/Authenticator/LoginLinkAuthenticatorTest.php

@@ -50,7 +50,7 @@ public function testSupport(array $options, $request, bool $supported)
         $this->assertEquals($supported, $this->authenticator->supports($request));
     }
 
-    public function provideSupportData()
+    public static function provideSupportData()
     {
         yield [['check_route' => '/validate_link'], Request::create('/validate_link?hash=abc123'), true];
         yield [['check_route' => '/validate_link'], Request::create('/login?hash=abc123'), false];

Tests/Authenticator/RememberMeAuthenticatorTest.php

@@ -51,7 +51,7 @@ public function testSupports($request, $support)
         $this->assertSame($support, $this->authenticator->supports($request));
     }
 
-    public function provideSupportsData()
+    public static function provideSupportsData()
     {
         yield [Request::create('/'), false];
 

Tests/Authenticator/RemoteUserAuthenticatorTest.php

@@ -64,7 +64,7 @@ public function testAuthenticate(InMemoryUserProvider $userProvider, RemoteUserA
         $this->assertTrue($user->isEqualTo($passport->getUser()));
     }
 
-    public function provideAuthenticators()
+    public static function provideAuthenticators()
     {
         $userProvider = new InMemoryUserProvider();
         yield [$userProvider, new RemoteUserAuthenticator($userProvider, new TokenStorage(), 'main'), 'REMOTE_USER'];

Tests/EventListener/CheckCredentialsListenerTest.php

@@ -62,7 +62,7 @@ public function testPasswordAuthenticated($password, $passwordValid, $result)
         }
     }
 
-    public function providePasswords()
+    public static function providePasswords()
     {
         yield ['ThePa$$word', true, true];
         yield ['Invalid', false, false];
@@ -100,7 +100,7 @@ public function testCustomAuthenticated($result)
         }
     }
 
-    public function provideCustomAuthenticatedResults()
+    public static function provideCustomAuthenticatedResults()
     {
         yield [true];
         yield [false];

Tests/EventListener/CheckRememberMeConditionsListenerTest.php

@@ -80,7 +80,7 @@ public function testSuccessfulLoginWithOptInRequestParameter($optInValue)
         $this->assertTrue($passport->getBadge(RememberMeBadge::class)->isEnabled());
     }
 
-    public function provideRememberMeOptInValues()
+    public static function provideRememberMeOptInValues()
     {
         yield ['true'];
         yield ['1'];