[Conformance checker] Eliminate redundant recording of missing witnesses.

DougGregor · DougGregor · commit f956e4f7041d · 2020-09-18T17:40:44.000-07:00
diff --git a/lib/Sema/TypeCheckProtocol.cpp b/lib/Sema/TypeCheckProtocol.cpp
@@ -3800,8 +3800,7 @@ ResolveWitnessResult ConformanceChecker::resolveWitnessViaDefault(
     recordOptionalWitness(requirement);
     return ResolveWitnessResult::Success;
   }
-  // Save the missing requirement for later diagnosis.
-  GlobalMissingWitnesses.insert({requirement, {}});
+
   return ResolveWitnessResult::ExplicitFailed;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3800,8 +3800,7 @@ ResolveWitnessResult ConformanceChecker::resolveWitnessViaDefault(`
`3800`	`3800`	`recordOptionalWitness(requirement);`
`3801`	`3801`	`return ResolveWitnessResult::Success;`
`3802`	`3802`	`}`
`3803`		`- // Save the missing requirement for later diagnosis.`
`3804`		`- GlobalMissingWitnesses.insert({requirement, {}});`
	`3803`	`+`
`3805`	`3804`	`return ResolveWitnessResult::ExplicitFailed;`
`3806`	`3805`	`}`
`3807`	`3806`