Rename getFiles to getFilesToEmit

Rename the member on ASTLoweringDescriptor and
IRGenDescriptor to make it more explicit it returns
the files that need emitting, rather than just the
files that happen to be present. This distinction
will become important once we start emitting code
only for a specific set of symbols.

Author: hamishknight

include/swift/AST/IRGenRequests.h

@@ -199,7 +199,7 @@ struct IRGenDescriptor {
   }
 
   /// Retrieves the files to perform IR generation for.
-  TinyPtrVector<FileUnit *> getFiles() const;
+  TinyPtrVector<FileUnit *> getFilesToEmit() const;
 
   /// For a single file, returns its parent module, otherwise returns the module
   /// itself.

include/swift/AST/SILGenRequests.h

@@ -75,9 +75,9 @@ struct ASTLoweringDescriptor {
     return ASTLoweringDescriptor{mod, conv, opts};
   }
 
-  /// For a single file input, returns a single element array containing that
-  /// file. Otherwise returns an array of each file in the module.
-  ArrayRef<FileUnit *> getFiles() const;
+  /// Retrieves the files to generate SIL for. If the descriptor is configured
+  /// only to emit a specific set of SILDeclRefs, this will be empty.
+  ArrayRef<FileUnit *> getFilesToEmit() const;
 
   /// If the module or file contains SIL that needs parsing, returns the file
   /// to be parsed, or \c nullptr if parsing isn't required.

lib/IRGen/IRGen.cpp

@@ -930,7 +930,7 @@ GeneratedModule IRGenRequest::evaluate(Evaluator &evaluator,
       return GeneratedModule::null();
   }
 
-  auto filesToEmit = desc.getFiles();
+  auto filesToEmit = desc.getFilesToEmit();
   auto *primaryFile =
       dyn_cast_or_null<SourceFile>(desc.Ctx.dyn_cast<FileUnit *>());
 

lib/IRGen/IRGenRequests.cpp

@@ -52,7 +52,7 @@ SourceLoc swift::extractNearestSourceLoc(const IRGenDescriptor &desc) {
   return SourceLoc();
 }
 
-TinyPtrVector<FileUnit *> IRGenDescriptor::getFiles() const {
+TinyPtrVector<FileUnit *> IRGenDescriptor::getFilesToEmit() const {
   // For a whole module, we emit IR for all files.
   if (auto *mod = Ctx.dyn_cast<ModuleDecl *>())
     return TinyPtrVector<FileUnit *>(mod->getFiles());

lib/SILGen/SILGen.cpp

@@ -1947,14 +1947,14 @@ ASTLoweringRequest::evaluate(Evaluator &evaluator,
                                              desc.opts);
   SILGenModuleRAII scope(*silMod);
 
-  for (auto file : desc.getFiles()) {
+  for (auto file : desc.getFilesToEmit()) {
     if (auto *nextSF = dyn_cast<SourceFile>(file))
       scope.emitSourceFile(nextSF);
   }
 
   // Also make sure to process any intermediate files that may contain SIL.
   bool shouldDeserialize =
-      llvm::any_of(desc.getFiles(), [](const FileUnit *File) -> bool {
+      llvm::any_of(desc.getFilesToEmit(), [](const FileUnit *File) -> bool {
         return isa<SerializedASTFile>(File);
       });
   if (shouldDeserialize) {

lib/SILGen/SILGenRequests.cpp

@@ -60,7 +60,7 @@ evaluator::DependencySource ASTLoweringRequest::readDependencySource(
   return {dyn_cast<SourceFile>(unit), evaluator::DependencyScope::Cascading};
 }
 
-ArrayRef<FileUnit *> ASTLoweringDescriptor::getFiles() const {
+ArrayRef<FileUnit *> ASTLoweringDescriptor::getFilesToEmit() const {
   if (auto *mod = context.dyn_cast<ModuleDecl *>())
     return mod->getFiles();
 
@@ -71,18 +71,18 @@ ArrayRef<FileUnit *> ASTLoweringDescriptor::getFiles() const {
 
 SourceFile *ASTLoweringDescriptor::getSourceFileToParse() const {
 #ifndef NDEBUG
-  auto sfCount = llvm::count_if(getFiles(), [](FileUnit *file) {
+  auto sfCount = llvm::count_if(getFilesToEmit(), [](FileUnit *file) {
     return isa<SourceFile>(file);
   });
-  auto silFileCount = llvm::count_if(getFiles(), [](FileUnit *file) {
+  auto silFileCount = llvm::count_if(getFilesToEmit(), [](FileUnit *file) {
     auto *SF = dyn_cast<SourceFile>(file);
     return SF && SF->Kind == SourceFileKind::SIL;
   });
   assert(silFileCount == 0 || (silFileCount == 1 && sfCount == 1) &&
          "Cannot currently mix a .sil file with other SourceFiles");
 #endif
 
-  for (auto *file : getFiles()) {
+  for (auto *file : getFilesToEmit()) {
     // Skip other kinds of files.
     auto *SF = dyn_cast<SourceFile>(file);
     if (!SF)