code review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/SpringDocConfiguration.java

@@ -92,21 +92,21 @@ PropertyCustomizingConverter propertyCustomizingConverter(Optional<List<Property
 	}
 
 	@Bean
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name="fileSupportConverter")
 	@Lazy(false)
 	FileSupportConverter fileSupportConverter() {
 		return new FileSupportConverter();
 	}
 
 	@Bean
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name="responseSupportConverter")
 	@Lazy(false)
 	ResponseSupportConverter responseSupportConverter() {
 		return new ResponseSupportConverter();
 	}
 
 	@Bean
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name="openAPIBuilder")
 	OpenAPIBuilder openAPIBuilder(Optional<OpenAPI> openAPI, ApplicationContext context,
 			SecurityParser securityParser,
 			SpringDocConfigProperties springDocConfigProperties,
@@ -122,7 +122,7 @@ ModelConverterRegistrar modelConverterRegistrar(Optional<List<ModelConverter>> m
 
 	@Bean
 	@ConditionalOnWebApplication
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name="operationBuilder")
 	OperationBuilder operationBuilder(GenericParameterBuilder parameterBuilder, RequestBodyBuilder requestBodyBuilder,
 			SecurityParser securityParser, PropertyResolverUtils propertyResolverUtils) {
 		return new OperationBuilder(parameterBuilder, requestBodyBuilder,
@@ -136,13 +136,13 @@ PropertyResolverUtils propertyResolverUtils(ConfigurableBeanFactory factory) {
 
 	@Bean
 	@ConditionalOnWebApplication
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name="requestBodyBuilder")
 	RequestBodyBuilder requestBodyBuilder(GenericParameterBuilder parameterBuilder) {
 		return new RequestBodyBuilder(parameterBuilder);
 	}
 
 	@Bean
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name="securityParser")
 	SecurityParser securityParser(PropertyResolverUtils propertyResolverUtils) {
 		return new SecurityParser(propertyResolverUtils);
 	}
@@ -153,7 +153,7 @@ ReturnTypeParser genericReturnTypeParser() {
 	}
 
 	@Bean
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name="parameterBuilder")
 	GenericParameterBuilder parameterBuilder(PropertyResolverUtils propertyResolverUtils) {
 		return new GenericParameterBuilder(propertyResolverUtils);
 	}

springdoc-openapi-data-rest/src/main/java/org/springdoc/data/rest/SpringDocDataRestConfiguration.java

@@ -65,7 +65,7 @@ public class SpringDocDataRestConfiguration {
 	class QuerydslProvider {
 
 		@Bean
-		@ConditionalOnMissingBean
+		@ConditionalOnMissingBean(name="queryDslQuerydslPredicateOperationCustomizer")
 		@Lazy(false)
 		QuerydslPredicateOperationCustomizer queryDslQuerydslPredicateOperationCustomizer(Optional<QuerydslBindingsFactory> querydslBindingsFactory) {
 			if (querydslBindingsFactory.isPresent()) {
@@ -78,14 +78,14 @@ QuerydslPredicateOperationCustomizer queryDslQuerydslPredicateOperationCustomize
 
 
 	@Bean
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name="halProvider")
 	@Lazy(false)
 	HalProvider halProvider(Optional<RepositoryRestConfiguration> repositoryRestConfiguration) {
 		return new HalProvider(repositoryRestConfiguration);
 	}
 
 	@Bean
-	@ConditionalOnMissingBean
+	@ConditionalOnMissingBean(name = "collectionModelContentConverter")
 	@Lazy(false)
 	CollectionModelContentConverter collectionModelContentConverter(HalProvider halProvider, LinkRelationProvider linkRelationProvider) {
 		return halProvider.isHalEnabled() ? new CollectionModelContentConverter(linkRelationProvider) : null;
@@ -98,6 +98,7 @@ CollectionModelContentConverter collectionModelContentConverter(HalProvider halP
 	 * @see org.springframework.hateoas.mediatype.hal.Jackson2HalModule.HalLinkListSerializer#serialize(Links, JsonGenerator, SerializerProvider)
 	 */
 	@Bean
+	@ConditionalOnMissingBean(name = "linksSchemaCustomiser")
 	@Lazy(false)
 	OpenApiCustomiser linksSchemaCustomiser(HalProvider halProvider) {
 		if (!halProvider.isHalEnabled()) {

springdoc-openapi-kotlin/src/main/java/org/springdoc/kotlin/SpringDocKotlinConfiguration.java

@@ -23,6 +23,7 @@
 import kotlin.Deprecated;
 import kotlin.coroutines.Continuation;
 
+import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
@@ -43,6 +44,7 @@ public class SpringDocKotlinConfiguration {
 
 	@Bean
 	@Lazy(false)
+	@ConditionalOnMissingBean(name = "kotlinCoroutinesReturnTypeParser")
 	KotlinCoroutinesReturnTypeParser kotlinCoroutinesReturnTypeParser() {
 		return new KotlinCoroutinesReturnTypeParser();
 	}