Skip to content

Conversation

@phoeenniixx
Copy link
Member

There is an Unpickling Error in weight loading of pytorch-forecasting-v1 because the weights are not loaded correctly.
The issue seems to be something related to torch which is leading to fail in CI/CD pipeline.

The issue surfaced after the latest lightning update where they exposed the weights_only param and let torch handle it itself.

Fixes #1998

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@aae13ba). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2000   +/-   ##
=======================================
  Coverage        ?   86.98%           
=======================================
  Files           ?      160           
  Lines           ?     9476           
  Branches        ?        0           
=======================================
  Hits            ?     8243           
  Misses          ?     1233           
  Partials        ?        0           
Flag Coverage Δ
cpu 86.98% <100.00%> (?)
pytest 86.98% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 3, 2025

hm, not yet, right?

@phoeenniixx
Copy link
Member Author

Yes, this PR is incomplete until we find a way to pass weights_only to tuner.

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 3, 2025

would overriding tuner work? Feels dangerous, but if we are forced to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

[BUG] Unpickling Error in weight loading

2 participants