Merge pull request #1879 from seleniumbase/some-refactoring

Some refactoring

Author: mdmintz

examples/test_download_files.py

@@ -5,6 +5,9 @@
 
 class DownloadTests(BaseCase):
     def test_download_chromedriver_notes(self):
+        if self._multithreaded:
+            self.open_if_not_url("about:blank")
+            self.skip("Skipping test in multi-threaded mode.")
         self.open("https://chromedriver.chromium.org/downloads")
         notes_file = "notes.txt"
         notes_link = (

examples/test_todomvc.py

@@ -4,13 +4,7 @@
 
 
 class TodoMVC(BaseCase):
-    @parameterized.expand(
-        [
-            ["mithril"],
-            ["react"],
-            ["vue"],
-        ]
-    )
+    @parameterized.expand([["jquery"], ["react"], ["vue"]])
     def test_todomvc(self, framework):
         self.open("https://todomvc.com/")
         self.clear_local_storage()

examples/user_agent_test.py

@@ -4,6 +4,9 @@
 
 class UserAgentTests(BaseCase):
     def test_user_agent(self):
+        if self._multithreaded:
+            self.open_if_not_url("about:blank")
+            self.skip("Skipping test in multi-threaded mode.")
         self.open("https://my-user-agent.com/")
         zoom_in = "#ua_string{zoom: 1.8;-moz-transform: scale(1.8);}"
         self.add_css_style(zoom_in)

mkdocs_build/requirements.txt

@@ -15,7 +15,7 @@ ghp-import==2.1.0
 readme-renderer==37.3
 pymdown-extensions==9.11
 importlib-metadata==6.6.0
-pipdeptree==2.7.0
+pipdeptree==2.7.1
 bleach==6.0.0
 lunr==0.6.2
 nltk==3.8.1
@@ -27,7 +27,7 @@ cssselect2==0.7.0
 tinycss2==1.2.1
 defusedxml==0.7.1
 mkdocs==1.4.3
-mkdocs-material==9.1.11
+mkdocs-material==9.1.12
 mkdocs-exclude-search==0.6.5
 mkdocs-simple-hooks==0.1.5
 mkdocs-material-extensions==1.1.1

requirements.txt

@@ -19,7 +19,7 @@ certifi>=2023.5.7
 filelock>=3.4.1;python_version<"3.7"
 filelock>=3.12.0;python_version>="3.7"
 platformdirs>=2.4.0;python_version<"3.7"
-platformdirs>=3.5.0;python_version>="3.7"
+platformdirs>=3.5.1;python_version>="3.7"
 pyparsing>=3.0.7;python_version<"3.7"
 pyparsing>=3.0.9;python_version>="3.7"
 zipp==3.6.0;python_version<"3.7"

seleniumbase/__version__.py

@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "4.14.8"
+__version__ = "4.14.9"

seleniumbase/fixtures/base_case.py

@@ -13644,14 +13644,20 @@ def setUp(self, masterqa_mode=False):
             # Pure Python run. Eg. SB() Manager
             self.__activate_virtual_display_as_needed()
 
-        # Verify that SeleniumBase is installed successfully
+        # Verify SeleniumBase is installed successfully, and used correctly
         if not hasattr(self, "browser"):
             raise Exception(
-                "SeleniumBase plugins DID NOT load! * Please REINSTALL!\n"
-                "*** Either install SeleniumBase in Dev Mode from a clone:\n"
+                "SeleniumBase plugins DID NOT load!\n"
+                'Either "seleniumbase" is not installed on your system,\n'
+                'or you called "setUp()" directly without initialization!\n'
+                "*** To install SeleniumBase in Develop Mode from a clone:\n"
                 '    >>> "pip install -e ."     (Run in DIR with setup.py)\n'
-                "*** Or install the latest SeleniumBase version from PyPI:\n"
-                '    >>> "pip install -U seleniumbase"    (Run in any DIR)'
+                "*** To install the latest SeleniumBase version from PyPI:\n"
+                '    >>> "pip install -U seleniumbase"    (Run in any DIR)\n'
+                'NOTE: "setUp()" can ONLY be called after vars are set.\n'
+                '    If using "pytest", then "pytest_plugin.py" sets them.\n'
+                '    The SeleniumBase "SB()" Manager can also set them.\n'
+                "See SeleniumBase/help_docs/syntax_formats.md for details!"
             )
 
         if not hasattr(sb_config, "_is_timeout_changed"):

setup.py

@@ -143,7 +143,7 @@
         'filelock>=3.4.1;python_version<"3.7"',
         'filelock>=3.12.0;python_version>="3.7"',
         'platformdirs>=2.4.0;python_version<"3.7"',
-        'platformdirs>=3.5.0;python_version>="3.7"',
+        'platformdirs>=3.5.1;python_version>="3.7"',
         'pyparsing>=3.0.7;python_version<"3.7"',
         'pyparsing>=3.0.9;python_version>="3.7"',
         'zipp==3.6.0;python_version<"3.7"',