Refactor CDP Mode

Author: mdmintz

seleniumbase/undetected/cdp_driver/browser.py

@@ -633,7 +633,7 @@ async def start(self=None) -> Browser:
                 """ % (dashes, message, dashes)
             )
         self.connection = Connection(
-            self.info.webSocketDebuggerUrl, _owner=self
+            self.info.webSocketDebuggerUrl, browser=self
         )
         if self.config.autodiscover_targets:
             logger.info("Enabling autodiscover targets")
@@ -807,7 +807,7 @@ async def update_targets(self):
                             f"/{t.target_id}"
                         ),
                         target=t,
-                        _owner=self,
+                        browser=self,
                     )
                 )
         await asyncio.sleep(0)

seleniumbase/undetected/cdp_driver/cdp_util.py

@@ -719,18 +719,6 @@ def start_sync(*args, **kwargs) -> Browser:
         loop = kwargs["loop"]
     else:
         loop = asyncio.new_event_loop()
-    if "user_data_dir" in kwargs and kwargs["user_data_dir"]:
-        headless = False
-        if "headless" in kwargs:
-            headless = kwargs["headless"]
-        decoy_args = kwargs
-        decoy_args["headless"] = True
-        driver = loop.run_until_complete(start(**decoy_args))
-        kwargs["headless"] = headless
-        kwargs["user_data_dir"] = driver.config.user_data_dir
-        time.sleep(0.2)
-        driver.stop()  # Due to Chrome-130, must stop & start
-        time.sleep(0.1)
     return loop.run_until_complete(start(*args, **kwargs))
 
 

seleniumbase/undetected/cdp_driver/connection.py

@@ -184,13 +184,13 @@ def __init__(
         self,
         websocket_url=None,
         target=None,
-        _owner=None,
+        browser=None,
         **kwargs,
     ):
         super().__init__()
         self._target = target
         self.__count__ = itertools.count(0)
-        self._owner = _owner
+        self.browser = browser
         self.websocket_url: str = websocket_url
         self.websocket = None
         self.mapper = {}
@@ -426,8 +426,8 @@ async def send(
         await self.aopen()
         if not self.websocket or self.websocket.state is State.CLOSED:
             return
-        if self._owner:
-            browser = self._owner
+        if self.browser:
+            browser = self.browser
             if browser.config:
                 if browser.config.expert:
                     await self._prepare_expert()