Merge pull request #1987 from seleniumbase/cft-support-and-recorder-fixes

Chrome-for-Testing support, Recorder Mode fixes, and more

Author: mdmintz

README.md

@@ -617,6 +617,7 @@ pytest test_coffee_cart.py --trace
 --extension-zip=ZIP  # (Load a Chrome Extension .zip|.crx, comma-separated.)
 --extension-dir=DIR  # (Load a Chrome Extension directory, comma-separated.)
 --binary-location=PATH  # (Set path of the Chromium browser binary to use.)
+--driver-version=VER  # (Set the chromedriver or uc_driver version to use.)
 --sjw  # (Skip JS Waits for readyState to be "complete" or Angular to load.)
 --pls=PLS  # (Set pageLoadStrategy on Chrome: "normal", "eager", or "none".)
 --headless  # (Run tests in headless mode. The default arg on Linux OS.)
@@ -1329,7 +1330,7 @@ pytest --reruns=1 --reruns-delay=1
 <span><a href="https://www.youtube.com/playlist?list=PLp9uKicxkBc5UIlGi2BuE3aWC7JyXpD3m"><img src="https://seleniumbase.github.io/cdn/img/youtube.png" title="SeleniumBase Playlist on YouTube" alt="SeleniumBase Playlist on YouTube" width="68" /></a></span>
 <span><a href="https://github.com/seleniumbase/SeleniumBase"><img src="https://seleniumbase.github.io/img/social/share_github.svg" title="SeleniumBase on GitHub" alt="SeleniumBase on GitHub" width="62" /></a></span>
 <span><a href="https://www.facebook.com/SeleniumBase"><img src="https://seleniumbase.io/img/social/share_facebook.svg" title="SeleniumBase on Facebook" alt="SeleniumBase on Facebook" width="64" /></a></span>
-<span><a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://seleniumbase.github.io/img/social/share_gitter.svg" title="SeleniumBase on Gitter" alt="SeleniumBase on Gitter" width="50" /></a></span>
+<span><a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://seleniumbase.github.io/img/social/share_gitter.svg" title="SeleniumBase on Gitter" alt="SeleniumBase on Gitter" width="52" /></a></span>
 </div></p>
 
 <p><div><a href="https://github.com/mdmintz">https://github.com/mdmintz</a></div></p>

examples/nth_child_test.py

@@ -6,7 +6,7 @@ class NthChildSelectorTests(BaseCase):
     def test_locate_rows_with_colors(self):
         self.open("https://xkcd.com/color/rgb/")
         tbody = "center > table tbody"
-        if not (self.headless or self.headless2 or self.xvfb):
+        if self.headed:
             self.demo_mode = True
             self.demo_sleep = 0.5
             self.message_duration = 2.0

examples/offline_examples/test_demo_page.py

@@ -48,21 +48,21 @@ def test_demo_page(self):
 
         # Verify that a slider control updates a progress bar
         self.assert_element('progress[value="50"]')
-        self.press_right_arrow("#myslider", times=5)
+        self.set_value("input#mySlider", "100")
         self.assert_element('progress[value="100"]')
 
         # Verify that a "select" option updates a meter bar
         self.assert_element('meter[value="0.25"]')
         self.select_option_by_text("#mySelect", "Set to 75%")
         self.assert_element('meter[value="0.75"]')
 
-        # Assert an element located inside an iFrame
+        # Assert an element located inside an iframe
         self.assert_false(self.is_element_visible("img"))
         self.switch_to_frame("#myFrame1")
         self.assert_true(self.is_element_visible("img"))
         self.switch_to_default_content()
 
-        # Assert text located inside an iFrame
+        # Assert text located inside an iframe
         self.assert_false(self.is_text_visible("iFrame Text"))
         self.switch_to_frame("#myFrame2")
         self.assert_true(self.is_text_visible("iFrame Text"))
@@ -89,7 +89,7 @@ def test_demo_page(self):
         self.assert_true(self.is_selected("#checkBox3"))
         self.assert_true(self.is_selected("#checkBox4"))
 
-        # Verify that clicking an iFrame checkbox selects it
+        # Verify that clicking an iframe checkbox selects it
         self.assert_false(self.is_element_visible(".fBox"))
         self.switch_to_frame("#myFrame3")
         self.assert_true(self.is_element_visible(".fBox"))

examples/raw_parameter_script.py

@@ -77,9 +77,10 @@
     sb._crumbs = False
     sb._final_debug = False
     sb.use_wire = False
-    sb.visual_baseline = False
+    sb.enable_3d_apis = False
     sb.window_size = None
     sb.maximize_option = False
+    sb.visual_baseline = False
     sb._disable_beforeunload = False
     sb.save_screenshot_after_test = False
     sb.no_screenshot_after_test = False
@@ -104,7 +105,7 @@
     sb._dash_initialized = False
     sb.message_duration = None
     sb.binary_location = None
-    sb.enable_3d_apis = False
+    sb.driver_version = None
     sb.block_images = False
     sb.do_not_track = False
     sb.external_pdf = False

examples/test_apple_site.py

@@ -4,7 +4,7 @@
 
 class AppleTests(BaseCase):
     def test_apple_developer_site_webdriver_instructions(self):
-        if not (self.headless or self.headless2 or self.xvfb):
+        if self.headed:
             self.demo_mode = True
             self.demo_sleep = 0.5
             self.message_duration = 2.0

examples/test_demo_site.py

@@ -43,21 +43,21 @@ def test_demo_site(self):
 
         # Verify that a slider control updates a progress bar
         self.assert_element('progress[value="50"]')
-        self.press_right_arrow("#myslider", times=5)
+        self.set_value("input#mySlider", "100")
         self.assert_element('progress[value="100"]')
 
         # Verify that a "select" option updates a meter bar
         self.assert_element('meter[value="0.25"]')
         self.select_option_by_text("#mySelect", "Set to 75%")
         self.assert_element('meter[value="0.75"]')
 
-        # Assert an element located inside an iFrame
+        # Assert an element located inside an iframe
         self.assert_false(self.is_element_visible("img"))
         self.switch_to_frame("#myFrame1")
         self.assert_true(self.is_element_visible("img"))
         self.switch_to_default_content()
 
-        # Assert text located inside an iFrame
+        # Assert text located inside an iframe
         self.assert_false(self.is_text_visible("iFrame Text"))
         self.switch_to_frame("#myFrame2")
         self.assert_true(self.is_text_visible("iFrame Text"))
@@ -84,7 +84,7 @@ def test_demo_site(self):
         self.assert_true(self.is_selected("#checkBox3"))
         self.assert_true(self.is_selected("#checkBox4"))
 
-        # Verify that clicking an iFrame checkbox selects it
+        # Verify that clicking an iframe checkbox selects it
         self.assert_false(self.is_element_visible(".fBox"))
         self.switch_to_frame("#myFrame3")
         self.assert_true(self.is_element_visible(".fBox"))
@@ -113,6 +113,7 @@ def test_demo_site(self):
         self.highlight("h2")
 
         # Actions with Demo Mode enabled
-        self.activate_demo_mode()
+        if self.headed:
+            self.activate_demo_mode()
         self.type("input", "Have a Nice Day!")
         self.assert_text("SeleniumBase", "h2")

examples/test_geolocation.py

@@ -37,5 +37,5 @@ def test_geolocation(self):
         self.click("span.geolocate")
         self.assert_url_contains("48.87645/2.26340")
         self.save_screenshot_to_logs()
-        if not (self.headless or self.headless2 or self.xvfb):
+        if self.headed:
             self.sleep(2.5)

examples/test_verify_chromedriver.py

@@ -1,30 +1,30 @@
+import sys
 from seleniumbase import BaseCase
 BaseCase.main(__name__, __file__)
 
 
 class ChromedriverTests(BaseCase):
-    def test_fail_if_using_an_old_chromedriver(self):
+    def test_fail_if_versions_dont_match(self):
         self.open("data:,")
         if self.browser != "chrome":
             self.open_if_not_url("data:,")
             print("\n  This test is only for Chrome!")
-            print("  (Run with: '--browser=chrome')")
+            print("  (Run with: '--chrome')")
             self.skip("This test is only for Chrome!")
         chrome_version = self.get_chrome_version()
         major_chrome_version = chrome_version.split(".")[0]
         chromedriver_version = self.get_chromedriver_version()
         major_chromedriver_version = chromedriver_version.split(".")[0]
-        install_sb = "sbase install chromedriver %s" % major_chrome_version
-        if (
-            int(major_chromedriver_version) < 73
-            and int(major_chrome_version) >= 73
-        ):
-            message = (
-                'Your version of chromedriver: "%s"\n  '
-                'is too old for your version of Chrome: "%s"\n'
-                "You should upgrade chromedriver "
-                "to receive important bug fixes!\n"
-                'Run this command to upgrade: "%s"'
-                % (chromedriver_version, chrome_version, install_sb)
-            )
-            raise Exception(message)  # chromedriver is out-of-date
+        install_sb = "sbase get chromedriver %s" % major_chrome_version
+        arg_join = " ".join(sys.argv)
+        message = (
+            'Your version of chromedriver: "%s"\n  '
+            'does not match your version of Chrome: "%s"\n'
+            'Run this command to fix that: "%s"'
+            % (chromedriver_version, chrome_version, install_sb)
+        )
+        if "--driver-version=" in arg_join or "--driver-version=" in arg_join:
+            if int(major_chromedriver_version) != int(major_chrome_version):
+                print("\nWarning -> " + message)
+        elif int(major_chromedriver_version) != int(major_chrome_version):
+            raise Exception(message)

examples/upgrade_chromedriver.py

@@ -92,3 +92,8 @@ def test_upgrade_chromedriver(self, testdir):
         # Print the final installed versions of chromedriver and Chrome
         testdir = self.print_versions_of_chromedriver_and_chrome(testdir)
         testdir.inline_run("--headless", "-s")
+
+
+if __name__ == "__main__":
+    from pytest import main
+    main([__file__])

examples/user_agent_test.py

@@ -19,7 +19,7 @@ def test_user_agent(self):
         else:
             # User-agent was overridden using: --agent=STRING
             print("\n\nUser-Agent override: %s" % user_agent_detected)
-        if not (self.headless or self.headless2 or self.xvfb):
+        if self.headed:
             self.sleep(2.75)
 
         # Now change the user-agent using "execute_cdp_cmd()"
@@ -46,7 +46,7 @@ def test_user_agent(self):
             self.highlight("#ua_string")
             user_agent_detected = self.get_text("#ua_string")
             print("\nUser-Agent override: %s" % user_agent_detected)
-            if not (self.headless or self.headless2 or self.xvfb):
+            if self.headed:
                 self.sleep(2.75)
         finally:
             # Reset the user-agent back to the original