Blog Post Day 5 2025 #888
Blog Post Day 5 2025 #888
Conversation
|
I requested reviewers on Discord, I suggest merging on Monday if there are no blockers by then |
I don't think this deals with unions at all. I think this is meant to say difference? |
docs/2025/puzzles/day05.md
Outdated
|
|
||
| Part 2 is a lot more complicated, but I've done [much worse](https://adventofcode.com/2021/day/22), so it wasn't too bad. | ||
|
|
||
| My common library has implementations for ranges that can intersect and combine with each other, but I'll reimplement them here |
There was a problem hiding this comment.
I'm a little curious, why implement a new range over NumericRange?
There was a problem hiding this comment.
NumericRange throws if your range is larger than the int limit - will add explanation to docs
| ```scala | ||
| type Input = (List[LRange], List[Long]) | ||
|
|
||
| final case class LRange(start: Long, end: Long): |
There was a problem hiding this comment.
I wonder if you should be excluding this from the file, then just use a common library that you import, and describe the logic there. I also understand having all logic in one file so you don't need prior knowledge (or dig into another file), but it would be cleaner.
There was a problem hiding this comment.
The blog post format requires we only use scala 3 standard library and include any and all code in the result
docs/2025/puzzles/day05.md
Outdated
| // toIterator to prevent Set from deduplicating our result | ||
| combinedRanges.toIterator.map(_.size).sum |
There was a problem hiding this comment.
Thanks for the writeup, I think it's written well! Minor nitpick: I believe .toIterator has been deprecated since 2.13, and should be replaced with .iterator instead.
There was a problem hiding this comment.
it has???? will fix that
|
I still want to do some work on the linked Diet sample so can you hold off on merging until I'm ready? |
|
alright no complaints from me anymore |
|
thanks all! |
5 participants
No description provided.