From 13764a50cd8d4215fcbbcafbcabe2892ccbd6552 Mon Sep 17 00:00:00 2001 From: glendc Date: Sun, 14 Dec 2025 21:01:30 +0100 Subject: [PATCH 1/2] fix aws verify 3rd party feature + add cargo-hack to CI --- .github/workflows/ci.yml | 15 +++++++++++++++ rcgen/Cargo.toml | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 167f03b7..022da5a8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -103,6 +103,21 @@ jobs: working-directory: rcgen/ run: cargo check-external-types --features aws_lc_rs_unstable,pem,x509-parser + cargo-hack: + name: Validate all feature combinations work + runs-on: ubuntu-latest + steps: + - name: Checkout sources + uses: actions/checkout@v6 + with: + persist-credentials: false + - name: Install rust toolchain + uses: dtolnay/rust-toolchain@stable + - name: install cargo-hack + uses: taiki-e/install-action@cargo-hack + - name: cargo hack check + run: cargo hack check --each-feature --no-dev-deps -p rcgen + semver: name: Check semver compatibility runs-on: ubuntu-latest diff --git a/rcgen/Cargo.toml b/rcgen/Cargo.toml index 331abacc..674aa490 100644 --- a/rcgen/Cargo.toml +++ b/rcgen/Cargo.toml @@ -12,7 +12,7 @@ keywords.workspace = true [features] default = ["crypto", "pem", "ring"] -aws_lc_rs = ["crypto", "dep:aws-lc-rs", "aws-lc-rs/aws-lc-sys", "x509-parser?/verify-aws"] +aws_lc_rs = ["crypto", "dep:aws-lc-rs", "aws-lc-rs/aws-lc-sys", "x509-parser?/verify-aws", "x509-parser?/verify"] aws_lc_rs_unstable = ["aws_lc_rs", "aws-lc-rs/unstable", "x509-parser?/verify-aws"] fips = ["crypto", "dep:aws-lc-rs", "aws-lc-rs/fips"] crypto = [] From 4d35dc700fcc19f99e09873482c7c5cde8b11da8 Mon Sep 17 00:00:00 2001 From: glendc Date: Mon, 15 Dec 2025 10:54:20 +0100 Subject: [PATCH 2/2] remove cargo-hack again, won't work for rcgen not all feature combos are compatible it seems, which in a way should not ever be true, but I do understand why it is done, so it is like it is... --- .github/workflows/ci.yml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 022da5a8..167f03b7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -103,21 +103,6 @@ jobs: working-directory: rcgen/ run: cargo check-external-types --features aws_lc_rs_unstable,pem,x509-parser - cargo-hack: - name: Validate all feature combinations work - runs-on: ubuntu-latest - steps: - - name: Checkout sources - uses: actions/checkout@v6 - with: - persist-credentials: false - - name: Install rust toolchain - uses: dtolnay/rust-toolchain@stable - - name: install cargo-hack - uses: taiki-e/install-action@cargo-hack - - name: cargo hack check - run: cargo hack check --each-feature --no-dev-deps -p rcgen - semver: name: Check semver compatibility runs-on: ubuntu-latest