fix(langserver): support for clients that do not implement pull diagnostics, e.g. neovim

Author: d-biehl

packages/language_server/src/robotcode/language_server/common/parts/diagnostics.py

@@ -141,11 +141,18 @@ def __init__(self, protocol: LanguageServerProtocol) -> None:
 
         self.refresh_task: Optional[asyncio.Task[Any]] = None
 
+        self.client_supports_pull = False
+
     async def initialized(self, sender: Any) -> None:
         self._ensure_diagnostics_thread_started()
 
         self._workspace_diagnostics_task = create_sub_task(self.run_workspace_diagnostics(), loop=self.diagnostics_loop)
 
+        if not self.client_supports_pull:
+            self.parent.documents.did_open.add(self.update_document_diagnostics)
+            self.parent.documents.did_change.add(self.update_document_diagnostics)
+            self.parent.documents.did_save.add(self.update_document_diagnostics)
+
     def extend_capabilities(self, capabilities: ServerCapabilities) -> None:
         if (
             self.parent.client_capabilities is not None
@@ -158,6 +165,7 @@ def extend_capabilities(self, capabilities: ServerCapabilities) -> None:
                 identifier=f"robotcodelsp_{uuid.uuid4()}",
                 work_done_progress=True,
             )
+            self.client_supports_pull = True
 
     @property
     def diagnostics_loop(self) -> asyncio.AbstractEventLoop:
@@ -486,6 +494,9 @@ def publish_diagnostics(self, document: TextDocument, diagnostics: List[Diagnost
             ),
         )
 
+    async def update_document_diagnostics(self, sender: Any, document: TextDocument) -> None:
+        self.create_document_diagnostics_task(document, True)
+
     @rpc_method(name="textDocument/diagnostic", param_type=DocumentDiagnosticParams)
     @threaded()
     async def _text_document_diagnostic(

src/robotcode/cli/__init__.py

@@ -130,6 +130,7 @@
     "--debugpy-wait-for-client",
     is_flag=True,
     hidden=show_hidden_arguments(),
+    show_envvar=True,
     help="Waits for a debugpy client to connect before starting the debugpy session.",
 )
 @click.version_option(version=__version__, prog_name="robotcode")