refactor(langserver): remove async code from diagnostics, selection range, workspace, signature help

Author: d-biehl

packages/core/src/robotcode/core/concurrent.py

@@ -126,7 +126,8 @@ def run_in_thread(callable: Callable[..., _TResult], *args: Any, **kwargs: Any)
         )
         _running_callables[future] = thread
         future.add_done_callback(_remove_future_from_running_callables)
-
+    # TODO: don't set daemon=True because it can be deprecated in future pyhton versions
+    thread.daemon = True
     thread.start()
 
     return future

packages/core/src/robotcode/core/event.py

@@ -73,6 +73,7 @@ def __iter__(self) -> Iterator[Callable[_TParams, _TResult]]:
     def _notify(
         self,
         *__args: _TParams.args,
+        return_exceptions: Optional[bool] = True,
         callback_filter: Optional[Callable[[Callable[..., Any]], bool]] = None,
         **__kwargs: _TParams.kwargs,
     ) -> Iterator[Union[_TResult, BaseException]]:
@@ -83,7 +84,10 @@ def _notify(
             try:
                 yield method(*__args, **__kwargs)
             except BaseException as e:
-                yield e
+                if return_exceptions:
+                    yield e
+                else:
+                    raise
 
 
 class EventIterator(EventResultIteratorBase[_TParams, _TResult]):

packages/jsonrpc2/src/robotcode/jsonrpc2/protocol.py

@@ -561,15 +561,15 @@ def send_request(
         self,
         method: str,
         params: Optional[Any] = None,
-        return_type_or_converter: Optional[Type[_TResult]] = None,
+        return_type: Optional[Type[_TResult]] = None,
     ) -> FutureEx[_TResult]:
         result: FutureEx[_TResult] = FutureEx()
 
         with self._sended_request_lock:
             self._sended_request_count += 1
             id = self._sended_request_count
 
-            self._sended_request[id] = SendedRequestEntry(result, return_type_or_converter)
+            self._sended_request[id] = SendedRequestEntry(result, return_type)
 
         request = JsonRPCRequest(id=id, method=method, params=params)
         self.send_message(request)
@@ -580,9 +580,9 @@ def send_request_async(
         self,
         method: str,
         params: Optional[Any] = None,
-        return_type: Optional[Type[_TResult]] = None,
+        return_type_or_converter: Optional[Type[_TResult]] = None,
     ) -> asyncio.Future[_TResult]:
-        return asyncio.wrap_future(self.send_request(method, params, return_type))
+        return asyncio.wrap_future(self.send_request(method, params, return_type_or_converter))
 
     @__logger.call
     def send_notification(self, method: str, params: Any) -> None: