Update based on Atif's review feedback

Signed-off-by: Keith Chong <kykchong@redhat.com>

Author: keithchong

src/gitops/components/rollout/RolloutRevisionsTab.tsx

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { RouteComponentProps } from 'react-router';
 import classNames from 'classnames';
 import { PodKind } from 'src/components/topology/console/types';
 
@@ -12,10 +11,7 @@ import { Flex, FlexItem, PageSection, PageSectionVariants, Title } from '@patter
 import { ReplicaSetKind, RolloutKind } from './model/RolloutModel';
 import { Revisions } from './revisions/Revisions';
 
-type RolloutRevisionsTabProps = RouteComponentProps<{
-  ns: string;
-  name: string;
-}> & {
+type RolloutRevisionsTabProps = {
   obj?: RolloutKind;
 };
 

src/gitops/components/rollout/components/AnalysisRunStatus/AnalysisRunStatus.tsx

@@ -47,7 +47,8 @@ export const AnalysisRunStatusFragment: React.FC<AnalysisRunStatusProps> = ({
       color = 'green';
       break;
     }
-    case (AnalysisRunStatus.Failed, AnalysisRunStatus.Error): {
+    case AnalysisRunStatus.Failed:
+    case AnalysisRunStatus.Error: {
       icon = <AnalysisRunStatusFailureIcon />;
       color = 'red';
       break;
@@ -103,7 +104,7 @@ const Metrics: React.FC<MetricsProps> = ({ arInfo }) => {
       <DescriptionList
         isHorizontal
         isCompact
-        className="gitops_admin_plugin__tight_description_list"
+        className="gitops_plugin__tight_description_list"
       >
         <DescriptionListGroup>
           <DescriptionListTerm>Started At:</DescriptionListTerm>
@@ -256,7 +257,7 @@ function getMeasurementTooltip(measurement: Measurement) {
       <tr>
         <th style={{ whiteSpace: 'nowrap' }}>Finished At: </th>
         <td>
-          <Timestamp simple timestamp={measurement.startedAt} />
+          <Timestamp simple timestamp={measurement.finishedAt} />
         </td>
       </tr>
       {measurement.value && (

src/gitops/components/rollout/revisions/ReplicaSetInfo.ts

@@ -34,8 +34,8 @@ export type AnalysisRunInfo = {
 };
 
 export type PodInfo = {
-  readyReplicas: number;
-  replicas: number;
+  readyReplicas?: number;
+  replicas?: number;
   pods: PodKind[];
   ownerReferences: OwnerReference[];
 };
@@ -142,7 +142,7 @@ export const getReplicaSetInfo = async (
     [revision: string]: any;
   };
 
-  const revisions: RevisionsMap = [];
+  const revisions: RevisionsMap = {};
 
   // Go through each replicaset and add to list
   replicaSets.forEach((rs) => {