Move playwright installation to a build script

Author: Archmonger

pyproject.toml

@@ -71,15 +71,8 @@ installer = "uv"
 reactpy = "reactpy._console.cli:entry_point"
 
 [[tool.hatch.build.hooks.build-scripts.scripts]]
-# Note: `hatch` can't be called within `build-scripts` when installing packages in editable mode, so we have to write the commands long-form
 commands = [
-  'python "src/build_scripts/clean_js_dir.py"',
-  'bun install --cwd "src/js/packages/event-to-object"',
-  'bun run --cwd "src/js/packages/event-to-object" build',
-  'bun install --cwd "src/js/packages/@reactpy/client"',
-  'bun run --cwd "src/js/packages/@reactpy/client" build',
-  'bun install --cwd "src/js/packages/@reactpy/app"',
-  'bun run --cwd "src/js/packages/@reactpy/app" build',
+  "hatch --env default run javascript:build",
   'python "src/build_scripts/copy_dir.py" "src/js/node_modules/@pyscript/core/dist" "src/reactpy/static/pyscript"',
   'python "src/build_scripts/copy_dir.py" "src/js/node_modules/morphdom/dist" "src/reactpy/static/morphdom"',
 ]
@@ -90,15 +83,13 @@ artifacts = []
 #############################
 [tool.hatch.envs.hatch-test.scripts]
 run = [
+  'hatch --env default run "src/build_scripts/install_playwright.py"',
   "hatch --env default build -t wheel",
-  "playwright install chromium",
-  "playwright install-deps",
   "pytest{env:HATCH_TEST_ARGS:} {args}",
 ]
 run-cov = [
+  'hatch --env default run "src/build_scripts/install_playwright.py"',
   "hatch --env default build -t wheel",
-  "playwright install chromium",
-  "playwright install-deps",
   "coverage run -m pytest{env:HATCH_TEST_ARGS:} {args}",
 ]
 cov-combine = "coverage combine"
@@ -195,7 +186,6 @@ detached = true
 [tool.hatch.envs.javascript.scripts]
 check = [
   'hatch run javascript:build',
-  'bun install --cwd "src/js"',
   'bun run --cwd "src/js" lint',
   'bun run --cwd "src/js/packages/event-to-object" checkTypes',
   'bun run --cwd "src/js/packages/@reactpy/client" checkTypes',

src/build_scripts/copy_dir.py

@@ -31,6 +31,7 @@ def copy_files(source: Path, destination: Path) -> None:
     root_dir = Path(__file__).parent.parent.parent
     src = Path(root_dir / sys.argv[1])
     dest = Path(root_dir / sys.argv[2])
+    print(f"Copying files from '{sys.argv[1]}' to '{sys.argv[2]}'...")  # noqa: T201
 
     if not src.exists():
         logging.error("Source directory %s does not exist", src)

src/build_scripts/install_playwright.py

@@ -0,0 +1,17 @@
+# /// script
+# requires-python = ">=3.11"
+# dependencies = []
+# ///
+
+import subprocess
+
+print("Installing Playwright browsers...")  # noqa: T201
+
+# Install Chromium browser for Playwright, and fail if it cannot be installed
+subprocess.run(["playwright", "install", "chromium"], check=True)  # noqa: S607
+
+# Try to install system dependencies. We don't generate an exception if this fails
+# as *nix systems (such as WSL) return a failure code if there are *any* dependencies
+# that could be cleaned up via `sudo apt autoremove`. This occurs even if we weren't
+# the ones to install those dependencies in the first place.
+subprocess.run(["playwright", "install-deps"], check=False)  # noqa: S607