fix(Button): fix button prop inference when using as prop #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
force-pushed
the
fix-button-prop-infer
branch
from
d2ded2b to
afae825
Compare
jquense
reviewed
Dec 8, 2025
| return <Component {...props} {...buttonProps} ref={ref} />; | ||
| }, | ||
| ); | ||
| const Button: DynamicRefForwardingComponent<'button', ButtonProps> = |
Member
There was a problem hiding this comment.
IIRC the reason we didn't do this was to keep the type simple since button is used everywhere and the as types break or are complex in weird ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes type inference on custom element props such as event handlers. Previously it was all defaulting to button elements and ignoring
as