Code coverage of readline.

Author: Lukasa

hyper/http20/bufsocket.py

@@ -150,6 +150,9 @@ def readline(self):
         Read up to a newline from the network and returns it. The implicit
         maximum line length is the buffer size of the buffered socket.
 
+        Note that, unlike recv, this method absolutely *does* block until it
+        can read the line.
+
         :returns: A ``memoryview`` object containing the appropriate number of
             bytes. The data *must* be copied out by the caller before the next
             call to this function.

test/test_socket.py

@@ -5,8 +5,11 @@
 
 Test the BufferedSocket implementation in hyper.
 """
+import pytest
+
 import hyper.http20.bufsocket
 from hyper.http20.bufsocket import BufferedSocket
+from hyper.http20.exceptions import ConnectionResetError, LineTooLongError
 
 # Patch the select method in bufsocket to make sure that it always returns
 # the dummy socket as readable.
@@ -181,6 +184,29 @@ def test_readline_both(self, monkeypatch):
         assert b.readline().tobytes() == two
         assert b.readline().tobytes() == three
 
+    def test_socket_error_on_readline(self, monkeypatch):
+        monkeypatch.setattr(
+            hyper.http20.bufsocket.select, 'select', dummy_select
+        )
+        s = DummySocket()
+        b = BufferedSocket(s)
+
+        with pytest.raises(ConnectionResetError):
+            b.readline()
+
+    def test_socket_readline_too_long(self, monkeypatch):
+        monkeypatch.setattr(
+            hyper.http20.bufsocket.select, 'select', dummy_select
+        )
+        s = DummySocket()
+        b = BufferedSocket(s)
+
+        b._buffer_view[0:b._buffer_size] = b'0' * b._buffer_size
+        b._bytes_in_buffer = b._buffer_size
+
+        with pytest.raises(LineTooLongError):
+            b.readline()
+
 
 class DummySocket(object):
     def __init__(self):