ci: treat warnings as errors to prevent accumulation #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure pytest to fail CI on any warnings except PendingDeprecationWarning. This prevents the codebase from accumulating warnings like the 1500+ we recently had to clean up. - Add -Werror flag to pytest in both build and examples jobs - Add -Wdefault::PendingDeprecationWarning to keep these as warnings - Simplify examples job warning configuration for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Configure CI to treat all warnings as errors (except
PendingDeprecationWarning) to prevent warning accumulation and enforce immediate fixes.Motive
Mesa recently had 1,514 warnings across 366 tests, creating technical debt and degrading developer experience. While significant cleanup has reduced this to ~22 warnings, we need to prevent regression.
Without enforcement, warnings slowly accumulate as contributors add code that triggers new warnings. By the time someone notices, hundreds of warnings have built up, making cleanup overwhelming. Treating warnings as errors catches issues immediately at PR time when they're easiest to fix.
Implementation
Added
-Werror -Wdefault::PendingDeprecationWarningflags to pytest in both CI jobs:-Werror: Converts all warnings to errors, failing the build-Wdefault::PendingDeprecationWarning: ExemptsPendingDeprecationWarning, as listed in our deprecation policy.This means
DeprecationWarning,FutureWarning,UserWarning, andRuntimeWarningwill now fail CI, forcing contributors to fix them before merging.Simplified the examples job configuration to match the main build job for consistency.