Handle empty values (#2)

kimpepper · web-flow · commit 7aea6562ffac · 2020-05-12T14:08:07.000+10:00
* Handle empty values
* Fix linting
diff --git a/src/Metric.php b/src/Metric.php
@@ -33,7 +33,7 @@ abstract class Metric {
    *
    * @var \PNX\Prometheus\LabelledValue[]
    */
-  protected $labelledValues;
+  protected $labelledValues = [];
 
   /**
    * Metric constructor.
diff --git a/tests/Unit/GaugeTest.php b/tests/Unit/GaugeTest.php
@@ -35,4 +35,15 @@ public function testGauge() {
 
   }
 
+  /**
+   * Ensure a gauge with no values is valid.
+   *
+   * @covers ::__construct
+   * @covers ::getLabelledValues
+   */
+  public function testGaugeNoValues() {
+    $gauge = new Gauge("foo", "bar", "A test gauge");
+    $this->assertEmpty($gauge->getLabelledValues());
+  }
+
 }

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ abstract class Metric {`
`33`	`33`	`*`
`34`	`34`	`* @var \PNX\Prometheus\LabelledValue[]`
`35`	`35`	`*/`
`36`		`- protected $labelledValues;`
	`36`	`+ protected $labelledValues = [];`
`37`	`37`
`38`	`38`	`/**`
`39`	`39`	`* Metric constructor.`
Original file line number	Diff line number	Diff line change
`@@ -35,4 +35,15 @@ public function testGauge() {`
`35`	`35`
`36`	`36`	`}`
`37`	`37`
	`38`	`+ /**`
	`39`	`+ * Ensure a gauge with no values is valid.`
	`40`	`+ *`
	`41`	`+ * @covers ::__construct`
	`42`	`+ * @covers ::getLabelledValues`
	`43`	`+ */`
	`44`	`+ public function testGaugeNoValues() {`
	`45`	`+ $gauge = new Gauge("foo", "bar", "A test gauge");`
	`46`	`+ $this->assertEmpty($gauge->getLabelledValues());`
	`47`	`+ }`
	`48`	`+`
`38`	`49`	`}`