Use custom rule instead of custom sniff

MauricioFauth · MauricioFauth · commit baecb9872e12 · 2018-02-21T13:28:23.000-03:00
PHP_CodeSniffer v3.2.3 has fixed a bug that allows removal of the ValidVariableName custom sniff in favor of the custom rule.

Signed-off-by: Maurício Meneghini Fauth &lt;mauriciofauth@gmail.com&gt;
diff --git a/PMAStandard/Sniffs/NamingConventions/ValidVariableNameSniff.php b/PMAStandard/Sniffs/NamingConventions/ValidVariableNameSniff.php
diff --git a/PMAStandard/ruleset.xml b/PMAStandard/ruleset.xml
@@ -35,4 +35,9 @@
             <property name="ignoreNewlines" value="true" />
         </properties>
     </rule>
+
+    <!-- Variable names should be camelCased with the first letter lowercase. -->
+    <rule ref="Zend.NamingConventions.ValidVariableName">
+        <exclude name="Zend.NamingConventions.ValidVariableName.PrivateNoUnderscore" />
+    </rule>
 </ruleset>
diff --git a/composer.json b/composer.json
@@ -16,6 +16,6 @@
         "issues": "https://github.com/phpmyadmin/coding-standard/issues"
     },
     "require": {
-        "squizlabs/php_codesniffer": "^3.0"
+        "squizlabs/php_codesniffer": "^3.2.3"
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,6 @@`
`16`	`16`	`"issues": "https://github.com/phpmyadmin/coding-standard/issues"`
`17`	`17`	`},`
`18`	`18`	`"require": {`
`19`		`- "squizlabs/php_codesniffer": "^3.0"`
	`19`	`+ "squizlabs/php_codesniffer": "^3.2.3"`
`20`	`20`	`}`
`21`	`21`	`}`