Skip to content

Commit 2191077

Browse files
authored
Merge pull request #2 from php-etl/fix/attribute-class
Fixed the attribute class
2 parents 46ffa3b + fe7a422 commit 2191077

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

src/Pipeline.php

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,29 +18,30 @@ public function __construct(
1818
array $steps = [],
1919
) {
2020
foreach ($steps as $name => $type) {
21-
if (!is_string($name)) {
22-
if (
21+
if (
22+
!is_string($name)
23+
&& (
2324
$type instanceof Pipeline\StepExtractor
2425
|| $type instanceof Pipeline\StepTransformer
2526
|| $type instanceof Pipeline\StepLoader
26-
) {
27-
$this->steps[] = $type;
28-
}
27+
)
28+
) {
29+
$this->steps[] = $type;
2930
continue;
3031
}
3132

3233
if ($type === 'extractor') {
33-
$this->steps[] = new Pipeline\StepExtractor(name: $name);
34+
$this->steps[] = new Pipeline\StepExtractor(name: is_string($name) && strlen($name) > 0 ? $name : null);
3435
continue;
3536
}
3637

3738
if ($type === 'transformer') {
38-
$this->steps[] = new Pipeline\StepTransformer(name: $name);
39+
$this->steps[] = new Pipeline\StepTransformer(name: is_string($name) && strlen($name) > 0 ? $name : null);
3940
continue;
4041
}
4142

4243
if ($type === 'loader') {
43-
$this->steps[] = new Pipeline\StepLoader(name: $name);
44+
$this->steps[] = new Pipeline\StepLoader(name: is_string($name) && strlen($name) > 0 ? $name : null);
4445
continue;
4546
}
4647
}

src/Pipeline/StepExtractor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
final class StepExtractor
77
{
88
public function __construct(
9-
public string $name = 'extractor',
9+
public ?string $name = 'extractor',
1010
) {
1111
}
1212
}

src/Pipeline/StepLoader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
final class StepLoader
77
{
88
public function __construct(
9-
public string $name = 'loader',
9+
public ?string $name = 'loader',
1010
) {
1111
}
1212
}

src/Pipeline/StepTransformer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
final class StepTransformer
77
{
88
public function __construct(
9-
public string $name = 'transformer',
9+
public ?string $name = 'transformer',
1010
) {
1111
}
1212
}

0 commit comments

Comments
 (0)