Fix double urldecode on query param values #296

Romain Janvier · Romain Janvier · commit fc4ee24892c9 · 2018-11-19T16:11:23.000+01:00
diff --git a/src/Http/Url.php b/src/Http/Url.php
@@ -540,10 +540,6 @@ protected function parseUrl($url)
         foreach ((array) $query as $key => $value) {
             $this->info['query'][hex2bin($key)] = $value;
         }
-
-        array_walk_recursive($this->info['query'], function (&$value) {
-            $value = urldecode($value);
-        });
     }
 
     /**
diff --git a/tests/UrlTest.php b/tests/UrlTest.php
@@ -26,6 +26,7 @@ public function urlsParserProvider()
             ['http://www.innherred.no/kultur/2017/03/25/On-the-road-med-%C3%86-og-Hagen-14499028.ece', 'http://www.innherred.no/kultur/2017/03/25/On-the-road-med-%C3%86-og-Hagen-14499028.ece'],
             ['https://pbs.twimg.com/media/CvCZ90BXYAE5q80.png:large', 'https://pbs.twimg.com/media/CvCZ90BXYAE5q80.png:large'],
             ['http://img.bibo.kz/?7142389.jpg', 'http://img.bibo.kz/?7142389.jpg'],
+            ['https://twitter.com/search?q=google%2B&src=typd&lang=en', 'https://twitter.com/search?q=google%2B&src=typd&lang=en'],
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -540,10 +540,6 @@ protected function parseUrl($url)`
`540`	`540`	`foreach ((array) $query as $key => $value) {`
`541`	`541`	`$this->info['query'][hex2bin($key)] = $value;`
`542`	`542`	`}`
`543`		`-`
`544`		`- array_walk_recursive($this->info['query'], function (&$value) {`
`545`		`- $value = urldecode($value);`
`546`		`- });`
`547`	`543`	`}`
`548`	`544`
`549`	`545`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ public function urlsParserProvider()`
`26`	`26`	`['http://www.innherred.no/kultur/2017/03/25/On-the-road-med-%C3%86-og-Hagen-14499028.ece', 'http://www.innherred.no/kultur/2017/03/25/On-the-road-med-%C3%86-og-Hagen-14499028.ece'],`
`27`	`27`	`['https://pbs.twimg.com/media/CvCZ90BXYAE5q80.png:large', 'https://pbs.twimg.com/media/CvCZ90BXYAE5q80.png:large'],`
`28`	`28`	`['http://img.bibo.kz/?7142389.jpg', 'http://img.bibo.kz/?7142389.jpg'],`
	`29`	`+ ['https://twitter.com/search?q=google%2B&src=typd&lang=en', 'https://twitter.com/search?q=google%2B&src=typd&lang=en'],`
`29`	`30`	`];`
`30`	`31`	`}`
`31`	`32`