fixed tests, added UserAgent class

Author: oscarotero

src/Http/CurlDispatcher.php

@@ -21,7 +21,7 @@ class CurlDispatcher implements DispatcherInterface
         CURLOPT_ENCODING => '',
         CURLOPT_AUTOREFERER => true,
         CURLOPT_FOLLOWLOCATION => true,
-        CURLOPT_USERAGENT => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36',
+        CURLOPT_USERAGENT => 'Embed PHP library',
         CURLOPT_IPRESOLVE => CURL_IPRESOLVE_V4,
     ];
 
@@ -81,6 +81,10 @@ public function dispatch(Url $url)
         curl_setopt_array($connection, $this->config);
         curl_setopt($connection, CURLOPT_HTTPHEADER, ['Accept: text/html']);
 
+        if (($useragent = UserAgent::resolve($url)) !== null) {
+            curl_setopt($connection, CURLOPT_USERAGENT, $useragent);
+        }
+
         $curl = new CurlResult($connection);
 
         //Get only text responses

src/Http/UserAgent.php

@@ -0,0 +1,47 @@
+<?php
+
+namespace Embed\Http;
+
+/**
+ * Class to return the user agent used depending of the url.
+ * This is because some sites works better with some user agents
+ */
+abstract class UserAgent
+{
+    private static $patterns = [
+        'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36' => [
+        ]
+    ];
+
+    public static function add($useragent, $pattern)
+    {
+        if (!isset(self::$patterns[$useragent])) {
+            self::$patterns[$useragent] = (array) $pattern;
+            return;
+        }
+
+        $pattern = (array) $pattern;
+
+        foreach ($pattern as $v) {
+            if (!in_array($v, self::$patterns[$useragent])) {
+                self::$patterns[$useragent][] = $v;
+            }
+        }
+    }
+
+    /**
+     * Returns the user agent.
+     *
+     * @param Url $url
+     *
+     * @return string|null
+     */
+    public static function resolve(Url $url)
+    {
+        foreach (self::$patterns as $useragent => $pattern) {
+            if ($url->match($pattern)) {
+                return $useragent;
+            }
+        }
+    }
+}

tests/FileTest.php

@@ -31,11 +31,11 @@ public function testPdf()
     public function testOgg()
     {
         $this->assertEmbed(
-            'https://upload.wikimedia.org/wikipedia/commons/b/b5/I-15bis.ogg',
+            'https://ia801006.us.archive.org/34/items/popeye_349/popeye.ogv',
             [
                 'type' => 'video',
-                'code' => '<video controls><source src="https://upload.wikimedia.org/wikipedia/commons/b/b5/I-15bis.ogg"></video>',
-                'providerUrl' => 'https://wikimedia.org',
+                'code' => '<video controls><source src="https://ia801006.us.archive.org/34/items/popeye_349/popeye.ogv"></video>',
+                'providerUrl' => 'https://archive.org',
             ]
         );
     }

tests/WikipediaTest.php

@@ -7,7 +7,7 @@ class WikipediaTest extends AbstractTestCase
     public function testOne()
     {
         $description = <<<'EOT'
-Albert Einstein (/ˈaɪnstaɪn/; German: [ˈalbɛɐ̯t ˈaɪnʃtaɪn]; 14 March 1879 – 18 April 1955) was a German-born theoretical physicist. He developed the general theory of relativity, one of the two pillars of modern physics (alongside quantum mechanics). Einstein's work is also known for its influence on the philosophy of science. Einstein is best known in popular culture for his mass–energy equivalence formula E = mc2 (which has been dubbed "the world's most famous equation"). He received the 1921 Nobel Prize in Physics for his "services to theoretical physics", in particular his discovery of the law of the photoelectric effect, a pivotal step in the evolution of quantum theory. Near the beginning of his career, Einstein thought that Newtonian mechanics was no longer enough to reconcile the laws of classical mechanics with the laws of the electromagnetic field. This led him to develop his special theory of relativity. He realized, however, that the principle of relativity could also be extended to gravitational fields, and with...
+Albert Einstein (/ˈaɪnstaɪn/; German: [ˈalbɛɐ̯t ˈaɪnʃtaɪn]; 14 March 1879 – 18 April 1955) was a German-born theoretical physicist. He developed the general theory of relativity, one of the two pillars of modern physics (alongside quantum mechanics). Einstein's work is also known for its influence on the philosophy of science. Einstein is best known in popular culture for his mass–energy equivalence formula E = mc2 (which has been dubbed "the world's most famous equation"). He received the 1921 Nobel Prize in Physics "for his services to Theoretical Physics, and especially for his discovery of the law of the photoelectric effect", a pivotal step in the evolution of quantum theory. Near the beginning of his career, Einstein thought that Newtonian mechanics was no longer enough to reconcile the laws of classical mechanics with the laws of the electromagnetic field. This led him to develop his special theory of relativity. He realized, however, that the principle of relativity could also be extended to gravitational fields, and...
 EOT;
 
         $this->assertEmbed(