Reduce unnecessary operations

Author: cesarBLG

Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/Door.cs

@@ -183,22 +183,20 @@ public virtual void Update(float elapsedClockSeconds)
             switch(State)
             {
                 case DoorState.Opening:
-                    ClosingTimer.Stop();
                     if (!OpeningTimer.Started) OpeningTimer.Start();
-                    if (OpeningTimer.Triggered) State = DoorState.Open;
+                    if (OpeningTimer.Triggered)
+                    {
+                        State = DoorState.Open;
+                        OpeningTimer.Stop();
+                    }
                     break;
                 case DoorState.Closing:
-                    OpeningTimer.Stop();
                     if (!ClosingTimer.Started) ClosingTimer.Start();
-                    if (ClosingTimer.Triggered) State = DoorState.Closed;
-                    break;
-                case DoorState.Closed:
-                    ClosingTimer.Stop();
-                    OpeningTimer.Stop();
-                    break;
-                case DoorState.Open:
-                    ClosingTimer.Stop();
-                    OpeningTimer.Stop();
+                    if (ClosingTimer.Triggered)
+                    {
+                        State = DoorState.Closed;
+                        ClosingTimer.Stop();
+                    }
                     break;
             }
         }
@@ -215,6 +213,7 @@ public void SetDoor(bool open)
                 case DoorState.Closing:
                     if (!Locked && open)
                     {
+                        ClosingTimer.Stop();
                         State = DoorState.Opening;
                         Wagon.SignalEvent(Event.DoorOpen);
                         bool driverRightSide = (Side == DoorSide.Right) ^ Wagon.GetCabFlipped();
@@ -225,6 +224,7 @@ public void SetDoor(bool open)
                 case DoorState.Opening:
                     if (!open)
                     {
+                        OpeningTimer.Stop();
                         State = DoorState.Closing;
                         Wagon.SignalEvent(Event.DoorClose);
                         bool driverRightSide = (Side == DoorSide.Right) ^ Wagon.GetCabFlipped();

Source/RunActivity/Viewer3D/RollingStock/MSTSLocomotiveViewer.cs

@@ -2433,7 +2433,7 @@ public void HandleUserInput()
                     {
                         bool right = (Control.ControlType == CABViewControlTypes.ORTS_RIGHTDOOR) ^ Locomotive.Flipped ^ Locomotive.GetCabFlipped();
                         var state = Locomotive.Train.DoorState(right ? DoorSide.Right : DoorSide.Left);
-                        int open = (state == DoorState.Opening || state == DoorState.Open) ? 1 : 0;
+                        int open = state >= DoorState.Open ? 1 : 0;
                         if (open != ChangedValue(open))
                         {
                             if (right) new ToggleDoorsRightCommand(Viewer.Log);
@@ -3156,7 +3156,7 @@ public override void PrepareFrame(RenderFrame frame, ElapsedTime elapsedTime)
                             {
                                 bool right = (p.Value.Type == CABViewControlTypes.RIGHTDOOR) ^ Locomotive.Flipped ^ Locomotive.GetCabFlipped();
                                 var state = (right ? Locomotive.RightDoor : Locomotive.LeftDoor).State;
-                                p.Value.UpdateState(state == DoorState.Open || state == DoorState.Opening, elapsedTime);
+                                p.Value.UpdateState(state >= DoorState.Open, elapsedTime);
                             }
                             break;
                         case CABViewControlTypes.MIRRORS: