Skip to content

Add short arguments for openmc config options #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ahnaf-tahmid-chowdhury wants to merge 158 commits into
base: develop
Choose a base branch
from
Open

Add short arguments for openmc config options #3664

ahnaf-tahmid-chowdhury wants to merge 158 commits into from

Conversation

@ahnaf-tahmid-chowdhury
Copy link
Contributor

@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury commented Nov 29, 2025

This PR introduces short command-line arguments for the openmc config subcommand, enhancing usability and convenience.

The following short arguments have been added:

  • -p for --prefix
  • -i for --include-dir
  • -l for --lib-dir
  • -c for --cmake-dir
  • -L for --libs
  • -e for --extra-libs
  • -d for --extra-lib-dir

These changes were implemented by modifying src/config.cpp to update the print_config_usage function and the argument parsing logic within openmc_config_main.

shimwell and others added 30 commits July 19, 2024 01:25
@shimwell
draft scikit build core wheel
e9101ab
@shimwell
renamed executable
e857f45
@jon-proximafusion
linking libopenmc with openmc in cmakelists
61b7035
@jon-proximafusion
Merge branch 'scikit_build_core_wheel' of github.com:shimwell/openmc …
12cb43d 
…into scikit_build_core_wheel
@jon-proximafusion
updated docs for pip install that compiles
2541d50
@jon-proximafusion
pip install with cmake args in ci
f15e80f
@jon-proximafusion
added missing ,
3c98d8a
@jon-proximafusion
no need for manual creation of build dir
0aafd44
@shimwell
[skip ci] merged develop
12b4221
@shimwell
[skip ci] adding apt packages for read the docs
9ef3beb
@shimwell
[skip ci] trying ubuntu 22.04
40ceaad
@shimwell
[skip ci] added missing s
2c8cf71
@shimwell
adding gha actions
4c0075f
@shimwell
upper case ON for cmake args
4de0d94
@shimwell
added quotes to cmake args
688d688
@shimwell
keeping same filename
07a4dcd
@shimwell
running just pytest
9253977
@shimwell
[skip ci] corrected cmake arg passing example
1f01694
@shimwell
added diagnosis prints
6850217
@shimwell
Merge branch 'scikit_build_core_wheel' of github.com:shimwell/openmc …
a601de8 
…into scikit_build_core_wheel
@shimwell
removed 2nd pip install which was overwritting
97a3f22
@shimwell
Merge branch 'develop' into scikit_build_core_wheel
3ae207d
@shimwell
merge in develop
e40cf3b
@jon-proximafusion
matching simulation results from ci
0213392
@shimwell
using debug instead of on for DCMAKE_BUILD_TYPE
6e3e47e
@ahnaf-tahmid-chowdhury
scikit-build-core added
b4b4e3a
@ahnaf-tahmid-chowdhury
Add rpath
79ae016
@ahnaf-tahmid-chowdhury
Install by scikit-build-core
394b0f9
@ahnaf-tahmid-chowdhury
update python install doc
12aec22
@ahnaf-tahmid-chowdhury
add support for dev mode
564cb5f
ahnaf-tahmid-chowdhury and others added 19 commits April 18, 2025 20:14
@ahnaf-tahmid-chowdhury
add more tests
5b16e22
@ahnaf-tahmid-chowdhury
add 100% coverage
038c7ba
@ahnaf-tahmid-chowdhury
skip warning
eb123c1
@ahnaf-tahmid-chowdhury
install editable mode
e07d3f1
@ahnaf-tahmid-chowdhury
OPENMC_DEV_MODE condition
dc3a4d6
@ahnaf-tahmid-chowdhury
Merge branch 'openmc-dev:develop' into skbuild-minimal
a60e391
@ahnaf-tahmid-chowdhury
Merge branch 'openmc-dev:develop' into skbuild-minimal
4e7b6ff
@ahnaf-tahmid-chowdhury
Merge remote-tracking branch 'upstream/develop' into skbuild-minimal
3384aba
@ahnaf-tahmid-chowdhury
mcpl is optional now
5473ad8
@ahnaf-tahmid-chowdhury
Merge remote-tracking branch 'upstream/develop' into skbuild-minimal
bf012bc
@ahnaf-tahmid-chowdhury
use dagmc suggestion as example
47c759e
@ahnaf-tahmid-chowdhury
no need to set LD_LIBRARY_PATH
e927ab3
@ahnaf-tahmid-chowdhury
Merge remote-tracking branch 'upstream/develop' into skbuild-minimal
5350c64
@ahnaf-tahmid-chowdhury
Merge remote-tracking branch 'upstream/develop' into skbuild-minimal
a65134d
@ahnaf-tahmid-chowdhury
fix find_package
abb715a
@ahnaf-tahmid-chowdhury
build-dir="build"
3dea404
@ahnaf-tahmid-chowdhury
Merge remote-tracking branch 'upstream/develop' into skbuild-minimal
25c21d8
@ahnaf-tahmid-chowdhury
add openmc config
ff90898
@ahnaf-tahmid-chowdhury
Merge remote-tracking branch 'upstream/develop' into openmc-config
f5b0da5
@ahnaf-tahmid-chowdhury
Copy link
Contributor Author

ahnaf-tahmid-chowdhury commented Nov 29, 2025

This PR depends on PR #3339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shimwell shimwell Awaiting requested review from shimwell shimwell is a code owner

@paulromano paulromano Awaiting requested review from paulromano paulromano is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahnaf-tahmid-chowdhury @shimwell @jon-proximafusion