Skip to content

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Dec 6, 2025

Partial implementation of a spec refactoring to get some feedback before writing similar changes for other core reflection types.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8373223 to be approved

Issues

  • JDK-8373186: Improve readability of core reflection toString specifications (Enhancement - P4)
  • JDK-8373223: Improve readability of core reflection toString specifications (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28688/head:pull/28688
$ git checkout pull/28688

Update a local copy of the PR:
$ git checkout pull/28688
$ git pull https://git.openjdk.org/jdk.git pull/28688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28688

View PR using the GUI difftool:
$ git pr show -t 28688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28688.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2025

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8373186: Improve readability of core reflection toString specifications 8373186: Improve readability of core reflection toString specifications Dec 6, 2025
@openjdk openjdk bot added csr Pull request needs approved CSR before integration core-libs core-libs-dev@openjdk.org labels Dec 6, 2025
@openjdk
Copy link

openjdk bot commented Dec 6, 2025

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant