Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Dec 4, 2025

Trivial renaming to make it explicit that this class is only for old-gen.

Test: GHA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373087: Parallel: Rename PSGenerationPool to PSOldGenerationPool (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28657/head:pull/28657
$ git checkout pull/28657

Update a local copy of the PR:
$ git checkout pull/28657
$ git pull https://git.openjdk.org/jdk.git pull/28657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28657

View PR using the GUI difftool:
$ git pr show -t 28657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28657.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2025

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373087: Parallel: Rename PSGenerationPool to PSOldGenerationPool

Reviewed-by: tschatzl, jsikstro, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8373087 8373087: Parallel: Rename PSGenerationPool to PSOldGenerationPool Dec 4, 2025
@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 4, 2025
@openjdk
Copy link

openjdk bot commented Dec 4, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2025

Webrevs

Copy link
Member

@jsikstro jsikstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

There's a difference between EdenMutableSpacePool and SurvivorMutableSpacePool having "MutableSpace" in their names, but PSOldGenerationPool doesn't. I think we should remove the MutableSpace part, in a future RFE.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2025
Comment on lines 27 to 29
PSOldGenerationPool::PSOldGenerationPool(PSOldGen* old_gen,
const char* name,
bool support_usage_threshold) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation?

Suggested change
PSOldGenerationPool::PSOldGenerationPool(PSOldGen* old_gen,
const char* name,
bool support_usage_threshold) :
PSOldGenerationPool::PSOldGenerationPool(PSOldGen* old_gen,
const char* name,
bool support_usage_threshold) :

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 4, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2025
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

Going to push as commit ed5fc9a.
Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2025
@openjdk openjdk bot closed this Dec 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@albertnetymk Pushed as commit ed5fc9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants